Skip to content

Initial declaration of DMS type and GeodeticLatLonDMS type#346

Open
MendeBadra wants to merge 7 commits intoJuliaEarth:mainfrom
MendeBadra:add-DMS-LatLon
Open

Initial declaration of DMS type and GeodeticLatLonDMS type#346
MendeBadra wants to merge 7 commits intoJuliaEarth:mainfrom
MendeBadra:add-DMS-LatLon

Conversation

@MendeBadra
Copy link
Copy Markdown

I'm working on the issue #247 and I've figured, I should make an early pull request. I've declared DMS type and GeodeticLatLonDMS types. The idea is to make Degrees Minutes and Seconds representation using DMS.

@juliohm
Copy link
Copy Markdown
Member

juliohm commented Apr 1, 2026

@MendeBadra please let us know when the PR is ready for review. I see it still needs tests and adherence to the code style of the project.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.80%. Comparing base (2777f57) to head (4019310).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/utils.jl 0.00% 16 Missing ⚠️
src/crs/geographic/geodetic.jl 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
- Coverage   92.15%   90.80%   -1.36%     
==========================================
  Files          40       40              
  Lines        1810     1837      +27     
==========================================
  Hits         1668     1668              
- Misses        142      169      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants