Unnecessarily wide types with setindex!!

[mhauru]

julia> setindex!!([1.0], Real[1.0], :)
1-element Vector{Any}:
 1.0

The element type here should be Real, but is Any. I think the culprit may be this line:

BangBang.jl/src/NoBang/base.jl

Line 130 in 64fa046

T = promote_type(eltype(xs), typeof(v))

in

function _setindex(xs::AbstractArray, v, I...)
    T = promote_type(eltype(xs), typeof(v))
    blahblah

That's fine as long as the I is a single index, but if I is some sort of range-like thing, such as a Colon in my MWE, we should use eltype(v) instead of typeof(v).

[penelopeysm]

Ran into this inconsistency again today:

julia> setindex!!([0, 1, 2], 2.0, 1)
3-element Vector{Float64}:
 2.0
 1.0
 2.0

julia> setindex!!([0, 1, 2], [2.0, 3.0], 1:2)
3-element Vector{Any}:
 2.0
 3.0
 2