Mark setindex! on SizedArray as possible#45
Conversation
|
Thank you! |
|
Thanks @MasonProtter! I would ask you for a release; but maybe I can do one better. Turing.jl currently already uses BangBang quite heavily and in the near future that reliance will only increase. Seven of the eight most recent open issues are from current or ex-Turing devs, and I ran into a few more problems getting it to work with DimensionalData which I haven't gotten around to reporting :-) I am the only one left on the project now, but if you would like, I am happy to help maintain the repo and maybe even try to fix some of them. Obviously PRs will still need to be reviewed, but I can help with the grunt work of releases, CI, and stuff. |
|
Yes, that would be great! |
|
Amazing, thank you! I shall try to register and hope the bot picks up collaborator status... |
StaticArrays.SizedArrayis mutable and hassetindex!defined on it (method is defined here), so this PR allows BangBang to make use of it:Right now
BangBang.setindex!!errors as it tries to go through an immutable path, which hits JuliaArrays/StaticArrays.jl#1330: