Skip to content

Should Linesearch also contain Options? #128

@benedict-96

Description

@benedict-96

After merging the pull request #127 (that solves #111) it is probably worthwhile to think about whether the NonlinearSolver (and analogously for the Optimizer) and the Linesearch should both store an instance of Options?

After merging #127 we have:

struct Options{T}
x_abstol::T
x_reltol::T
x_suctol::T
f_abstol::T
f_reltol::T
f_suctol::T
f_mindec::T
g_restol::T
x_abstol_break::T
x_reltol_break::T
f_abstol_break::T
f_reltol_break::T
g_restol_break::T
allow_f_increases::Bool
min_iterations::Int
max_iterations::Int
warn_iterations::Int
show_trace::Bool
store_trace::Bool
extended_trace::Bool
show_every::Int
verbosity::Int
linesearch_nan_max_iterations::Int
linesearch_nan_factor::T
end

allocating this once is probably enough?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions