Avoid constructing MulAddMuls (#623)

Author: dkarrasch

src/blas/highlevel.jl

@@ -106,10 +106,14 @@ LinearAlgebra.generic_trimatdiv!(
     isunitc, A, C === B ? C : copyto!(C, B))
 
 # GEMV
-
+# legacy method
+LinearAlgebra.generic_matvecmul!(
+    Y::ROCVector, tA::AbstractChar, A::StridedROCMatrix, B::StridedROCVector,
+    _add::MulAddMul
+) = LinearAlgebra.generic_matvecmul!(Y, tA, A, B, _add.alpha, _add.beta)
 function LinearAlgebra.generic_matvecmul!(
     Y::ROCVector, tA::AbstractChar, A::StridedROCMatrix, B::StridedROCVector,
-    _add::MulAddMul,
+    alpha::Number, beta::Number,
 )
     mA, nA = tA == 'N' ? size(A) : reverse(size(A))
 
@@ -122,7 +126,6 @@ function LinearAlgebra.generic_matvecmul!(
     nA == 0 && return rmul!(Y, 0)
 
     T = eltype(Y)
-    alpha, beta = _add.alpha, _add.beta
     if alpha isa Union{Bool,T} && beta isa Union{Bool,T}
         α, β = T(alpha), T(beta)
         if T <: ROCBLASFloat && eltype(A) == eltype(B) == T
@@ -135,19 +138,22 @@ function LinearAlgebra.generic_matvecmul!(
             end
         end
     end
-    LinearAlgebra.generic_matmatmul!(Y, tA, 'N', A, B, MulAddMul(alpha, beta))
+    LinearAlgebra.generic_matmatmul!(Y, tA, 'N', A, B, alpha, beta)
 end
 
 #
 # BLAS 3
 #
-
-function LinearAlgebra.generic_matmatmul!(
+# legacy method
+LinearAlgebra.generic_matmatmul!(
     C::StridedROCVecOrMat, tA, tB, A::StridedROCVecOrMat,
     B::StridedROCVecOrMat, _add::MulAddMul,
+) = LinearAlgebra.generic_matmatmul!(C, tA, tB, A, B, _add.alpha, _add.beta)
+function LinearAlgebra.generic_matmatmul!(
+    C::StridedROCVecOrMat, tA, tB, A::StridedROCVecOrMat,
+    B::StridedROCVecOrMat, alpha::Number, beta::Number,
 )
     T = eltype(C)
-    alpha, beta = _add.alpha, _add.beta
     mA, nA = size(A, tA == 'N' ? 1 : 2), size(A, tA == 'N' ? 2 : 1)
     mB, nB = size(B, tB == 'N' ? 1 : 2), size(B, tB == 'N' ? 2 : 1)