Use UnsafeAtomics 0.3

[vchuravy]

No description provided.

[vchuravy]

] add Atomix#vc/unsafe_atomics UnsafeAtomics#master KernelAbstractions#vc/unsafe_atomics

[pxl-th]

Simple @atomic x[1] += 1f0, fails with error below.
Previously we'd dispatch from atomic_pointermodify to llvm_atomic_op, but now we do atomic_pointerreplace which triggers this error.

pxlth@Tower:~/.julia/dev/AMDGPU$ jl t.jl 
Precompiling AMDGPU...
  1 dependency successfully precompiled in 9 seconds. 124 already precompiled.
ERROR: LoadError: InvalidIRError: compiling MethodInstance for ker!(::AMDGPU.Device.ROCDeviceVector{Float32, 1}) resulted in invalid LLVM IR
Reason: unsupported call to an unknown function (call to ijl_get_nth_field_checked)
Stacktrace:
 [1] indexed_iterate
   @ ./namedtuple.jl:172
 [2] multiple call sites
   @ unknown:0
Reason: unsupported call to an unknown function (call to jl_f_tuple)
Stacktrace:
 [1] indexed_iterate
   @ ./namedtuple.jl:172
 [2] multiple call sites
   @ unknown:0
Reason: unsupported call to an unknown function (call to ijl_get_nth_field_checked)
Stacktrace:
 [1] atomic_pointermodify
   @ ~/.julia/packages/UnsafeAtomics/y7d6Q/ext/UnsafeAtomicsLLVM/atomics.jl:276
 [2] modify!
   @ ~/.julia/packages/UnsafeAtomics/y7d6Q/ext/UnsafeAtomicsLLVM/internal.jl:23
 [3] modify!
   @ ~/.julia/packages/UnsafeAtomics/y7d6Q/src/core.jl:11
 [4] modify!
   @ ~/.julia/packages/Atomix/2spi2/src/core.jl:33
 [5] ker!
   @ ~/.julia/dev/AMDGPU/t.jl:5
Reason: unsupported dynamic function invocation (call to atomic_pointerreplace)
Stacktrace:
 [1] atomic_pointermodify
   @ ~/.julia/packages/UnsafeAtomics/y7d6Q/ext/UnsafeAtomicsLLVM/atomics.jl:276
 [2] modify!
   @ ~/.julia/packages/UnsafeAtomics/y7d6Q/ext/UnsafeAtomicsLLVM/internal.jl:23
 [3] modify!
   @ ~/.julia/packages/UnsafeAtomics/y7d6Q/src/core.jl:11
 [4] modify!
   @ ~/.julia/packages/Atomix/2spi2/src/core.jl:33
 [5] ker!
   @ ~/.julia/dev/AMDGPU/t.jl:5

[vchuravy]

I guess I shouldn't have removed that code xD

Can you open a PR that re-adds it and adds a test?

[pxl-th]

Yeah, will do in a bit

[vchuravy]

Thanks Anton!

[vchuravy]

Can you run the tests again? I am travelling right now without access to GPUs :)

[pxl-th]

Yeah, they all pass now.