Adapt CPU vector to ROC backend fails since GPUArrays v11.2.1

[pvillacorta]

I cannot replicate the error in my PC since it was produced in buildkite, sorry for that.

ERROR: LoadError: TypeError: in typeassert, expected GPUArrays.DataRef, got a value of type AMDGPU.ROCArray{Float32, 1, AMDGPU.Runtime.Mem.HIPBuffer}
Stacktrace:
  [1] cached_alloc(f::AMDGPU.var"#39#41"{AMDGPU.Runtime.Mem.HIPBuffer, 1, Float32, Tuple{Int64}, Int64}, key::Tuple{UnionAll, AMDGPU.HIP.HIPDevice, DataType, DataType, Int64})
    @ GPUArrays ~/.cache/julia-buildkite-plugin/depots/018dadfb-f4d5-466e-8c3f-55b5f9a75025/packages/GPUArrays/Mot2g/src/host/alloc_cache.jl:36
  [2] AMDGPU.ROCArray{Float32, 1, AMDGPU.Runtime.Mem.HIPBuffer}(::UndefInitializer, dims::Tuple{Int64})
    @ AMDGPU ~/.cache/julia-buildkite-plugin/depots/018dadfb-f4d5-466e-8c3f-55b5f9a75025/packages/AMDGPU/yQoPL/src/array.jl:9
  [3] AMDGPU.ROCArray{Float32, 1, AMDGPU.Runtime.Mem.HIPBuffer}(x::Vector{Float32})
    @ AMDGPU ~/.cache/julia-buildkite-plugin/depots/018dadfb-f4d5-466e-8c3f-55b5f9a75025/packages/AMDGPU/yQoPL/src/array.jl:116
  [4] (AMDGPU.ROCArray{Float32, 1})(x::Vector{Float32})
    @ AMDGPU ~/.cache/julia-buildkite-plugin/depots/018dadfb-f4d5-466e-8c3f-55b5f9a75025/packages/AMDGPU/yQoPL/src/array.jl:121
  [5] AMDGPU.ROCArray(A::Vector{Float32})
    @ AMDGPU ~/.cache/julia-buildkite-plugin/depots/018dadfb-f4d5-466e-8c3f-55b5f9a75025/packages/AMDGPU/yQoPL/src/array.jl:124
  [6] convert(::Type{AMDGPU.ROCArray}, a::Vector{Float32})
    @ GPUArrays ~/.cache/julia-buildkite-plugin/depots/018dadfb-f4d5-466e-8c3f-55b5f9a75025/packages/GPUArrays/Mot2g/src/host/construction.jl:4
  [7] adapt_storage(::Type{AMDGPU.ROCArray}, xs::Vector{Float32})
    @ AMDGPU ~/.cache/julia-buildkite-plugin/depots/018dadfb-f4d5-466e-8c3f-55b5f9a75025/packages/AMDGPU/yQoPL/src/array.jl:215
  [8] adapt_structure(to::Type, x::Vector{Float32})
    @ Adapt ~/.cache/julia-buildkite-plugin/depots/018dadfb-f4d5-466e-8c3f-55b5f9a75025/packages/Adapt/VO8tI/src/Adapt.jl:57
  [9] adapt(to::Type, x::Vector{Float32})
    @ Adapt ~/.cache/julia-buildkite-plugin/depots/018dadfb-f4d5-466e-8c3f-55b5f9a75025/packages/Adapt/VO8tI/src/Adapt.jl:40
 [10] adapt_storage(::AMDGPU.ROCKernels.ROCBackend, a::Vector{Float32})
    @ AMDGPU.ROCKernels ~/.cache/julia-buildkite-plugin/depots/018dadfb-f4d5-466e-8c3f-55b5f9a75025/packages/AMDGPU/yQoPL/src/ROCKernels.jl:16
 [11] adapt_structure(to::AMDGPU.ROCKernels.ROCBackend, x::Vector{Float32})
    @ Adapt ~/.cache/julia-buildkite-plugin/depots/018dadfb-f4d5-466e-8c3f-55b5f9a75025/packages/Adapt/VO8tI/src/Adapt.jl:57
 [12] adapt(to::AMDGPU.ROCKernels.ROCBackend, x::Vector{Float32})
    @ Adapt ~/.cache/julia-buildkite-plugin/depots/018dadfb-f4d5-466e-8c3f-55b5f9a75025/packages/Adapt/VO8tI/src/Adapt.jl:40

It seems that it has been produced by the new type assertion introduced in GPUArrays.jl. Could this be an issue with AMDGPU.jl? It is the only one of the four backends that is giving me this error.

Thank you.

[pxl-th]

Did you update to AMDGPU@1.2.2?

Also can you show output of ]st or share a link to buildkite run?

[pvillacorta]

A silly mistake on my part, indeed. Only the GPUArrays version had been updated, but not AMDGPU. After updating it to v1.2.2, everything works correctly.

Thanks a lot! :)

[pxl-th]

Great! I'll close the issue then.