Skip to content

Conversation

@amontoison
Copy link
Member

@amontoison amontoison commented Mar 28, 2025

Regenerate the Julia wrappers for the following libraries:

  • rocsparse
  • rocfft
  • rocblas
  • rocsolver

@amontoison amontoison requested a review from pxl-th March 28, 2025 01:57
@pxl-th
Copy link
Member

pxl-th commented Mar 28, 2025

Is there some functionality missing in the old wrappers?

I am wondering if we should not replace all @CCall by @gc_ccall in the same time.

Why?

@amontoison
Copy link
Member Author

Because we could call the GC during a @ccall with this modification but it will be the default behaviour with Julia 1.12.

@amontoison
Copy link
Member Author

@pxl-th I updated the PR, all tests should passed now.
Yes, AMD added many routines during the last year in rocBLAS, rocSPARSE and rocSOLVER.
The generic API for rocSPARSE was quite incomplete before this PR.

@pxl-th pxl-th merged commit 01a9b02 into JuliaGPU:master Apr 24, 2025
3 checks passed
@pxl-th
Copy link
Member

pxl-th commented Apr 24, 2025

Thanks!

@amontoison amontoison deleted the headers branch April 24, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants