Define GPUArrays tests dynamically #863
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overcomes synchronisation issues related to GPUArrays test items being modified and and modifications not ported into AMDGPU test suite (ref #858).
There is however one limitation in the current situation related to the fact it does not seem possible to have an
@evalcall to construct test items dynamically from GPUArrays' test suite in the file used by ReTestItems as it only allows for@testsetupand@testitem. The current solution duplicates the test setup for KA by calling all GPUArrays test within a single test item. The caveat of this approach is that it prevents from running on multiple workers.