Skip to content

Adapt to KernelIntrinsics #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
christiangnrd wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Adapt to KernelIntrinsics #868

christiangnrd wants to merge 7 commits into from
+66 −27

Conversation

@christiangnrd
Copy link
Member

@christiangnrd christiangnrd commented Dec 12, 2025

No description provided.

@luraess luraess mentioned this pull request Dec 12, 2025
Open
@christiangnrd christiangnrd force-pushed the intrinsics branch 7 times, most recently from fd2048c to cfeceb2 Compare December 16, 2025 17:04
@christiangnrd
Remove irrelevant KA tests
659e65b 
These always run on the CPU backend which is currently broken in 1.12, creating false negatives for the GPU tests
@christiangnrd
Copy link
Member Author

christiangnrd commented Dec 18, 2025 •
edited
Loading

id for AMDGPU is used to identify whether we need to launch hostcalls, based on the specific id of the global variable. It is not needed for KA, so can be dropped as in https://github.com/JuliaGPU/AMDGPU.jl/pull/868/files#diff-082b94339c8f038178ee472ca9b6feec6f27f434c469138f168031f248f223f9R197.

(From JuliaGPU/KernelAbstractions.jl#666)

Is my changing static local code generation from LLVMExternalLinkage to LLVMInternalLinkage going to cause any unintended effects? I had to do so to prevent local memory allocations from being treated as the same one if there happen to be more than one in a kernel. Otherwise I think we’ll have to readd the id parameter.

@pxl-th
Copy link
Member

pxl-th commented Dec 19, 2025 •
edited
Loading

Is my changing static local code generation from LLVMExternalLinkage to LLVMInternalLinkage going to cause any unintended effects?

I don't think. I think it is a remnant from pre-HIP times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christiangnrd @pxl-th