[NFC] Split up tests into different files #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Wow, this is great - thanks for the time and effort put into this tests refactor, @christiangnrd ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking into the best way to reuse these tests in GPUArrays once it starts using these algorithms. I'm not there yet, but in the meantime, this PR organizes the tests in a similar manner to the
srcfolder.I was very careful to make sure that everything was copied over and the number of tests in main matches the number of tests in this PR.
If we decide the best way to proceed is by converting the tests into a testsuite similarly to how GPUArrays and KernelAbstractions tests are organized, it will be much easier with tests organized this way, otherwise it'll still make navigating the tests easier.