Don't manually disable finalizers before locking.

This is already done by Base.

Author: maleadt

lib/utils/cache.jl

@@ -17,23 +17,18 @@ end
 # remove a handle from the cache, or create a new one
 function Base.pop!(f::Function, cache::HandleCache{K,V}, key) where {K,V}
     function check_cache(f::Function=()->nothing)
-        try
-            GC.enable_finalizers(false)
-            lock(cache.lock) do
-                handle = if !haskey(cache.idle_handles, key) || isempty(cache.idle_handles[key])
-                    f()
-                else
-                    pop!(cache.idle_handles[key])
-                end
-
-                if handle !== nothing
-                    push!(cache.active_handles, key=>handle)
-                end
+        lock(cache.lock) do
+            handle = if !haskey(cache.idle_handles, key) || isempty(cache.idle_handles[key])
+                f()
+            else
+                pop!(cache.idle_handles[key])
+            end
 
-                return handle
+            if handle !== nothing
+                push!(cache.active_handles, key=>handle)
             end
-        finally
-            GC.enable_finalizers(true)
+
+            return handle
         end
     end