Merge pull request #162 from JuliaGPU/vc/chol

add ishermitian

Author: vchuravy

src/linalg.jl

@@ -89,10 +89,19 @@ function LinearAlgebra.permutedims!(dest::GPUArray, src::GPUArray, perm::NTuple{
     return dest
 end
 
-
-function Base.copyto!(A::AbstractArray, B::Adjoint{T, <: GPUArray}) where T
-    copyto!(A, Adjoint(Array(B.parent)))
+function Base.copyto!(A::AbstractArray, B::Adjoint{<:Any, <:GPUArray})
+    copyto!(A, Adjoint(Array(parent(B))))
+end
+function Base.copyto!(A::AbstractArray, B::Transpose{<:Any, <:GPUArray})
+    copyto!(A, Transpose(Array(parent(B))))
+end
+function Base.copyto!(A::AbstractArray, B::UpperTriangular{<:Any, <:GPUArray})
+    copyto!(A, UpperTriangular(Array(parent(B))))
 end
+function Base.copyto!(A::AbstractArray, B::LowerTriangular{<:Any, <:GPUArray})
+    copyto!(A, LowerTriangular(Array(parent(B))))
+end
+
 function Base.copyto!(A::GPUArray, B::Adjoint{T, <: GPUArray}) where T
     transpose!(A, B.parent)
 end

src/mapreduce.jl

@@ -12,6 +12,8 @@ Base.count(pred::Function, A::GPUArray) = Int(mapreduce(pred, +, A; init = 0))
 
 Base.:(==)(A::GPUArray, B::GPUArray) = Bool(mapreduce(==, &, A, B; init = true))
 
+LinearAlgebra.ishermitian(A::GPUMatrix) = acc_mapreduce(==, &, true, A, (adjoint(A),))
+
 # hack to get around of fetching the first element of the GPUArray
 # as a startvalue, which is a bit complicated with the current reduce implementation
 function startvalue(f, T)
@@ -159,6 +161,9 @@ end
 
 to_cpu(x) = x
 to_cpu(x::GPUArray) = Array(x)
+to_cpu(x::LinearAlgebra.Transpose) = LinearAlgebra.Transpose(to_cpu(parent(x)))
+to_cpu(x::LinearAlgebra.Adjoint) = LinearAlgebra.Adjoint(to_cpu(parent(x)))
+to_cpu(x::SubArray) = SubArray(to_cpu(parent(x)), parentindices(x))
 
 function acc_mapreduce(
         f, op, v0::OT, A::GPUArray{T, N}, rest::Tuple

src/testsuite/linalg.jl

@@ -2,12 +2,27 @@ function test_linalg(AT)
     @testset "linear algebra" begin
         @testset "transpose" begin
             @test compare(adjoint, AT, rand(Float32, 32, 32))
+            @test compare(transpose, AT, rand(Float32, 32, 32))
         end
 
         @testset "permutedims" begin
             @test compare(x -> permutedims(x, (2, 1)), AT, rand(Float32, 2, 3))
             @test compare(x -> permutedims(x, (2, 1, 3)), AT, rand(Float32, 4, 5, 6))
             @test compare(x -> permutedims(x, (3, 1, 2)), AT, rand(Float32, 4, 5, 6))
         end
+
+        @testset "issymmetric/ishermitian" begin
+            n = 128
+            areal = randn(n,n)/2
+            aimg  = randn(n,n)/2
+
+            @testset for eltya in (Float32, Float64, ComplexF32, ComplexF64)
+                a = convert(Matrix{eltya}, eltya <: Complex ? complex.(areal, aimg) : areal)
+                asym = transpose(a) + a        # symmetric indefinite
+                aherm = a' + a                 # Hermitian indefinite
+                @test issymmetric(asym)
+                @test ishermitian(aherm)
+            end
+        end
     end
 end