Implement and test reshape for JLArray.

Author: maleadt

src/reference.jl

@@ -201,6 +201,17 @@ JLArray{T,N}(xs::JLArray{T,N}) where {T,N} = xs
 
 Base.convert(::Type{T}, x::T) where T <: JLArray = x
 
+function Base._reshape(parent::JLArray, dims::Dims)
+  n = length(parent)
+  prod(dims) == n || throw(DimensionMismatch("parent has $n elements, which is incompatible with size $dims"))
+  return JLArray{eltype(parent),length(dims)}(reshape(parent.data, dims), dims)
+end
+function Base._reshape(parent::JLArray{T,1}, dims::Tuple{Int}) where T
+  n = length(parent)
+  prod(dims) == n || throw(DimensionMismatch("parent has $n elements, which is incompatible with size $dims"))
+  return parent
+end
+
 
 ## broadcast
 

test/testsuite/base.jl

@@ -88,6 +88,15 @@ function test_base(AT)
             @test compare((a,b) -> cat(a, b; dims=4), AT, rand(Float32, 3, 4), rand(Float32, 3, 4))
         end
 
+        @testset "reshape" begin
+            @test compare(reshape, AT, rand(10), Ref((10,)))
+            @test compare(reshape, AT, rand(10), Ref((10,1)))
+            @test compare(reshape, AT, rand(10), Ref((1,10)))
+
+            @test reshape(AT(rand(10)), (10,1)) isa AT
+            @test_throws Exception reshape(AT(rand(10)), (10,2))
+        end
+
         @testset "reinterpret" begin
             a = rand(ComplexF32, 22)
             A = AT(a)