Skip to content

Commit f10d175

Browse files
committed
Simplify using at-cartesianidx.
1 parent 6d2b3d6 commit f10d175

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

src/host/linalg.jl

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,12 @@ function Base.copyto!(A::AbstractGPUArray, B::Adjoint{T, <: AbstractGPUArray}) w
4040
transpose!(A, B.parent)
4141
end
4242

43-
# TODO: simplify using CartesianIdx?
4443
function LinearAlgebra.tril!(A::AbstractGPUMatrix{T}, d::Integer = 0) where T
4544
function kernel!(ctx, _A, _d)
46-
li = @linearidx _A
47-
m, n = size(_A)
48-
if 0 < li <= m*n
49-
i, j = Tuple(CartesianIndices(_A)[li])
50-
if i < j - _d
51-
_A[i, j] = 0
52-
end
45+
I = @cartesianidx _A
46+
i, j = Tuple(I)
47+
if i < j - _d
48+
_A[i, j] = 0
5349
end
5450
return nothing
5551
end
@@ -58,16 +54,12 @@ function LinearAlgebra.tril!(A::AbstractGPUMatrix{T}, d::Integer = 0) where T
5854
return A
5955
end
6056

61-
# TODO: simplify using CartesianIdx?
6257
function LinearAlgebra.triu!(A::AbstractGPUMatrix{T}, d::Integer = 0) where T
6358
function kernel!(ctx, _A, _d)
64-
li = @linearidx _A
65-
m, n = size(_A)
66-
if 0 < li <= m*n
67-
i, j = Tuple(CartesianIndices(_A)[li])
68-
if j < i + _d
69-
_A[i, j] = 0
70-
end
59+
I = @cartesianidx _A
60+
i, j = Tuple(I)
61+
if j < i + _d
62+
_A[i, j] = 0
7163
end
7264
return nothing
7365
end

0 commit comments

Comments
 (0)