Don't collect iterators when we don't need to.

Author: maleadt

Manifest.toml

@@ -39,8 +39,8 @@ version = "1.3.0"
 
 [[LLVM]]
 deps = ["CEnum", "LLVMExtra_jll", "Libdl", "Printf", "Unicode"]
-git-tree-sha1 = "effe3552dba16b1e9c3cc9beac454a3566f09637"
-repo-rev = "b4dfdfcf86dde4563c87e90d130c78dbbe8550f8"
+git-tree-sha1 = "97b3606f7e23cc7afd594d8a094f1f087f1d6511"
+repo-rev = "2c5db93"
 repo-url = "https://github.com/maleadt/LLVM.jl.git"
 uuid = "929cbde3-209d-540e-8aea-75f648917ca0"
 version = "4.2.0"

src/gcn.jl

@@ -111,7 +111,7 @@ function lower_throw_extra!(mod::LLVM.Module)
                     end
 
                     # remove the call
-                    call_args = collect(operands(call))[1:end-1] # last arg is function itself
+                    call_args = operands(call)[1:end-1] # last arg is function itself
                     unsafe_delete!(LLVM.parent(call), call)
 
                     # HACK: kill the exceptions' unused arguments

src/irgen.jl

@@ -207,7 +207,7 @@ function lower_throw!(mod::LLVM.Module)
                 end
 
                 # remove the call
-                call_args = collect(operands(call))[1:end-1] # last arg is function itself
+                call_args = operands(call)[1:end-1] # last arg is function itself
                 unsafe_delete!(LLVM.parent(call), call)
 
                 # HACK: kill the exceptions' unused arguments
@@ -489,7 +489,7 @@ function lower_byval(@nospecialize(job::CompilerJob), mod::LLVM.Module, f::LLVM.
         # NOTE: we need global changes because LLVM 12 wants to clone debug metadata
 
         # fall through
-        br!(builder, collect(blocks(new_f))[2])
+        br!(builder, blocks(new_f)[2])
     end
 
     # remove the old function

src/optim.jl

@@ -242,7 +242,7 @@ function lower_gc_frame!(fun::LLVM.Function)
             call = user(use)::LLVM.CallInst
 
             # decode the call
-            ops = collect(operands(call))
+            ops = operands(call)
             sz = ops[2]
 
             # replace with PTX alloc_obj