Clone with local changes in more places. (#289)

maleadt · web-flow · commit bf93f585edbe · 2022-02-11T20:10:18.000+01:00
diff --git a/src/irgen.jl b/src/irgen.jl
@@ -483,7 +483,7 @@ function lower_byval(@nospecialize(job::CompilerJob), mod::LLVM.Module, f::LLVM.
             param => new_args[i] for (i,param) in enumerate(parameters(f))
         )
         clone_into!(new_f, f; value_map,
-                    changes=LLVM.API.LLVMCloneFunctionChangeTypeGlobalChanges)
+                    changes=LLVM.API.LLVMCloneFunctionChangeTypeLocalChangesOnly)
         # NOTE: we need global changes because LLVM 12 wants to clone debug metadata
 
         # fall through
diff --git a/src/spirv.jl b/src/spirv.jl
@@ -293,8 +293,7 @@ function wrap_byval(@nospecialize(job::CompilerJob), mod::LLVM.Module, f::LLVM.F
             param => new_args[i] for (i,param) in enumerate(parameters(f))
         )
         clone_into!(new_f, f; value_map,
-                    changes=LLVM.API.LLVMCloneFunctionChangeTypeGlobalChanges)
-        # NOTE: we need global changes because LLVM 12 wants to clone debug metadata
+                    changes=LLVM.API.LLVMCloneFunctionChangeTypeLocalChangesOnly)
 
         # apply byval attributes again (`clone_into!` didn't due to the type mismatch)
         for i in 1:length(byval)

Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,7 @@ function lower_byval(@nospecialize(job::CompilerJob), mod::LLVM.Module, f::LLVM.`
`483`	`483`	`param => new_args[i] for (i,param) in enumerate(parameters(f))`
`484`	`484`	`)`
`485`	`485`	`clone_into!(new_f, f; value_map,`
`486`		`- changes=LLVM.API.LLVMCloneFunctionChangeTypeGlobalChanges)`
	`486`	`+ changes=LLVM.API.LLVMCloneFunctionChangeTypeLocalChangesOnly)`
`487`	`487`	`# NOTE: we need global changes because LLVM 12 wants to clone debug metadata`
`488`	`488`
`489`	`489`	`# fall through`
Original file line number	Diff line number	Diff line change
`@@ -293,8 +293,7 @@ function wrap_byval(@nospecialize(job::CompilerJob), mod::LLVM.Module, f::LLVM.F`
`293`	`293`	`param => new_args[i] for (i,param) in enumerate(parameters(f))`
`294`	`294`	`)`
`295`	`295`	`clone_into!(new_f, f; value_map,`
`296`		`- changes=LLVM.API.LLVMCloneFunctionChangeTypeGlobalChanges)`
`297`		`- # NOTE: we need global changes because LLVM 12 wants to clone debug metadata`
	`296`	`+ changes=LLVM.API.LLVMCloneFunctionChangeTypeLocalChangesOnly)`
`298`	`297`
`299`	`298`	# apply byval attributes again (`clone_into!` didn't due to the type mismatch)
`300`	`299`	`for i in 1:length(byval)`