Skip to content

Conversation

@maleadt
Copy link
Member

@maleadt maleadt commented Mar 26, 2025

Addresses #668 (comment)

@github-actions
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/reflection.jl b/src/reflection.jl
index 4cae6f0..0f0bf1a 100644
--- a/src/reflection.jl
+++ b/src/reflection.jl
@@ -186,7 +186,7 @@ See also: [`@device_code_llvm`](@ref), `InteractiveUtils.code_llvm`
 function code_llvm(io::IO, @nospecialize(job::CompilerJob); optimize::Bool=true, raw::Bool=false,
                    debuginfo::Symbol=:default, dump_module::Bool=false, kwargs...)
     # NOTE: jl_dump_function_ir supports stripping metadata, so don't do it in the driver
-    config = CompilerConfig(job.config; validate=false, strip=false, optimize)
+    config = CompilerConfig(job.config; validate = false, strip = false, optimize)
     str = JuliaContext() do ctx
         ir, meta = compile(:llvm, CompilerJob(job; config))
         ts_mod = ThreadSafeModule(ir)

@maleadt maleadt enabled auto-merge (squash) March 26, 2025 13:02
@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.73%. Comparing base (2944591) to head (8c4ca35).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
- Coverage   68.27%   66.73%   -1.54%     
==========================================
  Files          24       24              
  Lines        3451     3451              
==========================================
- Hits         2356     2303      -53     
- Misses       1095     1148      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt maleadt disabled auto-merge April 23, 2025 14:29
@maleadt maleadt merged commit c4cda76 into master Apr 23, 2025
19 checks passed
@maleadt maleadt deleted the tb/reflection_optimize branch April 23, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants