-
Notifications
You must be signed in to change notification settings - Fork 59
Avoid closure in @safe_* macros #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oh shoot, this solution only works on <=1.10. The implementation was reworked to use ScopedValues for 1.11. That's why you don't try to rely on non-public API I guess. Any suggestions for a better way, @vchuravy? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 66.53% 66.57% +0.04%
==========================================
Files 24 24
Lines 3451 3459 +8
==========================================
+ Hits 2296 2303 +7
- Misses 1155 1156 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
|
This is ready for review if you're interested. AMDGPU.jl failures look unrelated. Looks like all the recent green commits skipped these tests due to unsatisfiable requirements. |
maleadt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #685
I noticed the testing of these macros was nuked in #658, so I didn't add any tests here, but I'm happy to add something akin to the #685 MWE if desired.