Skip to content

Conversation

@danielwe
Copy link
Contributor

@danielwe danielwe commented Apr 1, 2025

Fixes #685

I noticed the testing of these macros was nuked in #658, so I didn't add any tests here, but I'm happy to add something akin to the #685 MWE if desired.

@danielwe
Copy link
Contributor Author

danielwe commented Apr 1, 2025

Oh shoot, this solution only works on <=1.10. The implementation was reworked to use ScopedValues for 1.11. That's why you don't try to rely on non-public API I guess. Any suggestions for a better way, @vchuravy?

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.57%. Comparing base (e0a95d9) to head (104a6c7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/utils.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
+ Coverage   66.53%   66.57%   +0.04%     
==========================================
  Files          24       24              
  Lines        3451     3459       +8     
==========================================
+ Hits         2296     2303       +7     
- Misses       1155     1156       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025

Your PR no longer requires formatting changes. Thank you for your contribution!

@danielwe
Copy link
Contributor Author

This is ready for review if you're interested. AMDGPU.jl failures look unrelated. Looks like all the recent green commits skipped these tests due to unsatisfiable requirements.

Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maleadt maleadt merged commit edf2aa2 into JuliaGPU:master Apr 13, 2025
21 checks passed
@danielwe danielwe deleted the safeloggers branch April 13, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Safe logging macros don't work in generated functions due to with_logger closure

2 participants