Avoid closure in @safe_* macros#686
Conversation
|
Oh shoot, this solution only works on <=1.10. The implementation was reworked to use ScopedValues for 1.11. That's why you don't try to rely on non-public API I guess. Any suggestions for a better way, @vchuravy? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 66.53% 66.57% +0.04%
==========================================
Files 24 24
Lines 3451 3459 +8
==========================================
+ Hits 2296 2303 +7
- Misses 1155 1156 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
|
This is ready for review if you're interested. AMDGPU.jl failures look unrelated. Looks like all the recent green commits skipped these tests due to unsatisfiable requirements. |
Fixes #685
I noticed the testing of these macros was nuked in #658, so I didn't add any tests here, but I'm happy to add something akin to the #685 MWE if desired.