fix erase! call in src/gcn.jl

[simeonschaub]

No description provided.

[github-actions]

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.

diff --git a/src/gcn.jl b/src/gcn.jl
index 36165a2..1f32d46 100644
--- a/src/gcn.jl
+++ b/src/gcn.jl
@@ -87,7 +87,7 @@ function lower_throw_extra!(mod::LLVM.Module)
                     # remove the call
                     nargs = length(parameters(f))
                     call_args = arguments(call)
-                    erase!(call)
+                        erase!(call)
 
                     # HACK: kill the exceptions' unused arguments
                     for arg in call_args
diff --git a/test/gcn.jl b/test/gcn.jl
index 8e1f2ad..d07002c 100644
--- a/test/gcn.jl
+++ b/test/gcn.jl
@@ -21,21 +21,21 @@ sink_gcn(i) = sink(i, Val(5))
     end
 end
 
-@testset "bounds errors" begin
-    mod = @eval module $(gensym())
-        function kernel()
-            Base.throw_boundserror(1, 2)
-            return
-        end
-    end
+        @testset "bounds errors" begin
+            mod = @eval module $(gensym())
+            function kernel()
+                Base.throw_boundserror(1, 2)
+                return
+            end
+            end
 
-    @test @filecheck begin
-        check"CHECK-NOT: {{julia_throw_boundserror_[0-9]+}}"
-        check"CHECK: @gpu_report_exception"
-        check"CHECK: @gpu_signal_exception"
-        GCN.code_llvm(mod.kernel, Tuple{})
-    end
-end
+            @test @filecheck begin
+                check"CHECK-NOT: {{julia_throw_boundserror_[0-9]+}}"
+                check"CHECK: @gpu_report_exception"
+                check"CHECK: @gpu_signal_exception"
+                GCN.code_llvm(mod.kernel, Tuple{})
+            end
+        end
 
 end
 

[vchuravy]

Could you also add a test?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (a063141) to head (0224bad).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/gcn.jl	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #706       +/-   ##
==========================================
- Coverage   74.82%   0.00%   -74.83%     
==========================================
  Files          24      24               
  Lines        3523    3443       -80     
==========================================
- Hits         2636       0     -2636     
- Misses        887    3443     +2556     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[simeonschaub]

Other than the known nightly failures, CI looks green. Good to merge?