Skip to content

Conversation

@vchuravy
Copy link
Member

Should hopefully fix #742

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/GPUCompiler.jl b/src/GPUCompiler.jl
index 72bf085..2260b07 100644
--- a/src/GPUCompiler.jl
+++ b/src/GPUCompiler.jl
@@ -20,8 +20,8 @@ const ENABLE_TRACY = parse(Bool, @load_preference("tracy", "false"))
 Activate tracy in the current environment.
 You will need to restart your Julia environment for it to take effect.
 """
-function enable_tracy!(state::Bool=true)
-    @set_preferences!("tracy"=>string(state))
+function enable_tracy!(state::Bool = true)
+    return @set_preferences!("tracy" => string(state))
 end
 
 if ENABLE_TRACY
diff --git a/test/aqua.jl b/test/aqua.jl
index 54c6510..ebbbe3e 100644
--- a/test/aqua.jl
+++ b/test/aqua.jl
@@ -1,4 +1,6 @@
 using Aqua
 
-Aqua.test_all(GPUCompiler;
-    stale_deps=(ignore=[:Tracy],),)
+Aqua.test_all(
+    GPUCompiler;
+    stale_deps = (ignore = [:Tracy],),
+)

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.72%. Comparing base (531dccd) to head (25adc4c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/GPUCompiler.jl 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
- Coverage   75.28%   74.72%   -0.57%     
==========================================
  Files          24       24              
  Lines        3670     3675       +5     
==========================================
- Hits         2763     2746      -17     
- Misses        907      929      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vchuravy vchuravy merged commit 029dcdf into master Nov 26, 2025
28 of 33 checks passed
@vchuravy vchuravy deleted the vc/disable_tracy branch November 26, 2025 19:37
@maleadt
Copy link
Member

maleadt commented Nov 28, 2025

That's unfortunate. Is that kind of overhead expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Versions newer than 1.3.2 make Julia/CUDA/Flux slow

3 participants