Mark symbols public instead of exporting. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the nature of this package, I think we should encourage explicit import of functionality in the packages that depend on GPUToolbox. I originally didn't implement this, as Compat.jl adds a bunch of standard library dependencies to this no-dependency package, but then I found https://discourse.julialang.org/t/is-compat-jl-worth-it-for-the-public-keyword/119041/11. It's not pretty, but it works. Technically breaking, but all backends already explicity import the GPUToolbox functionality that they use, so it'll just be a matter of me adding "0.2" to the compat.
Merged
Member
|
Talking with Tim, we feel that things being exported ought to be the way to go, since we expect all functionality to be useful inside GPU backend packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the nature of this package, I think we should encourage explicit import of functionality in the packages that depend on GPUToolbox.
I originally didn't implement this, as Compat.jl adds a bunch of standard library dependencies to this no-dependency package, but then I found https://discourse.julialang.org/t/is-compat-jl-worth-it-for-the-public-keyword/119041/11.
It's not pretty, but it works.
Technically breaking, but all backends already explicity import the GPUToolbox functionality that they use, so it'll just be a matter of me opening PRs to add "0.2" to the compat for each of the packages.