Merge #228

228: overdub overflowerr_binaryop (#227) r=vchuravy a=vchuravy



Co-authored-by: Valentin Churavy <[email protected]>

Author: bors[bot]

src/compiler.jl

@@ -62,5 +62,14 @@ function generate_overdubs(mod, Ctx)
         end
 
         @inline Cassette.overdub(::$Ctx, ::typeof(Base.literal_pow), f::F, x, p) where F = Base.literal_pow(f, x, p)
+
+        if VERSION >= v"1.5"
+            @inline function Cassette.overdub(::$Ctx, ::typeof(Base.Checked.throw_overflowerr_binaryop), op, x, y)
+                throw(OverflowError("checked arithmetic: cannot compute"))
+            end
+            @inline function Cassette.overdub(::$Ctx, ::typeof(Base.Checked.throw_overflowerr_negation), x)
+                throw(OverflowError("checked arithmetic: cannot compute -x"))
+            end
+        end
     end
 end

test/compiler.jl

@@ -12,15 +12,26 @@ end
     A[1] = 2^11
 end
 
+@kernel function checked(A, a, b)
+    A[1] = Base.Checked.checked_add(a, b)
+end
+
 function compiler_testsuite()
     kernel = index(CPU(), DynamicSize(), DynamicSize())
     iterspace = NDRange{1, StaticSize{(128,)}, StaticSize{(8,)}}();
     ctx = KernelAbstractions.mkcontext(kernel, 1, nothing, iterspace, Val(KernelAbstractions.NoDynamicCheck()))
 
     @test KernelAbstractions.Cassette.overdub(ctx, KernelAbstractions.__index_Global_NTuple, CartesianIndex(1)) == (1,)
 
-    CI, rt = @ka_code_typed literal_pow(CPU())(zeros(Int,1), ndrange=1)
-    # test that there is no invoke of overdub
-    @test !any(stmt->(stmt isa Expr) && stmt.head == :invoke, CI.code)
-end
+    let (CI, rt) = @ka_code_typed literal_pow(CPU())(zeros(Int,1), ndrange=1)
+        # test that there is no invoke of overdub
+        @test !any(stmt->(stmt isa Expr) && stmt.head == :invoke, CI.code)
+    end
 
+    if VERSION >= v"1.5"
+        let (CI, rt) = @ka_code_typed checked(CPU())(zeros(Int,1), 1, 2, ndrange=1)
+            # test that there is no invoke of overdub
+            @test !any(stmt->(stmt isa Expr) && stmt.head == :invoke, CI.code)
+        end
+    end
+end