avoid boxing when @kernel is used as a closure
#625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows uses of `@kernel` inside of functions without running into JuliaLang/julia#53295. One thing I have been wondering though: Is the `@isdefined` check here really necessary? In global scope it should just override the previous definition and for closures these kind of if statements are ignored anyways.
|
This was added in 2896ef7 Which probably was meant to avoid re-definition warnings when defining a kernel with multiple methods. |
|
Ah, I see! It's probably fine to leave as-is for now. Does this workaround seem reasonable to you otherwise? |
|
Should be okay. @maleadt has asked for this before. |
|
Can you also add a PR against main? |
|
Will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows uses of
@kernelinside of functions without running intoJuliaLang/julia#53295. One thing I have been wondering though: Is the
@isdefinedcheck here really necessary? In global scope it should justoverride the previous definition and for closures these kind of if
statements are ignored anyways.