Skip to content

Disable Float16 on the CPU backend #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025
Merged

Disable Float16 on the CPU backend #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9a4b2f
Disable Float16 on the CPU backend
vchuravy Jun 10, 2025
337ce9a
warn when support is broken
vchuravy Jun 10, 2025
15fad45
Update src/pocl/compiler/compilation.jl
vchuravy Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions benchmark/benchmarks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,16 @@ using Random

if !haskey(ENV, "KA_BACKEND")
const BACKEND = CPU()
const Ts = (Float32, Float64)
else
backend = ENV["KA_BACKEND"]
if backend == "CPU"
const BACKEND = CPU()
const Ts = (Float32, Float64)
elseif backend == "CUDA"
using CUDA
const BACKEND = CUDABackend()
const Ts = (Float16, Float32, Float64)
else
error("Backend $backend not recognized")
end
Expand All @@ -31,7 +34,7 @@ end
SUITE["saxpy"] = BenchmarkGroup()

let static = BenchmarkGroup()
for T in (Float16, Float32, Float64)
for T in Ts
dtype = BenchmarkGroup()
for N in (64, 256, 512, 1024, 2048, 4096, 16384, 32768, 65536, 262144, 1048576)
dtype[N] = @benchmarkable begin
Expand All @@ -49,7 +52,7 @@ let static = BenchmarkGroup()
end

let default = BenchmarkGroup()
for T in (Float16, Float32, Float64)
for T in Ts
dtype = BenchmarkGroup()
for N in (64, 256, 512, 1024, 2048, 4096, 16384, 32768, 65536, 262144, 1048576)
dtype[N] = @benchmarkable begin
Expand Down
1 change: 1 addition & 0 deletions src/pocl/compiler/compilation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ end
supports_fp16 = "cl_khr_fp16" in dev.extensions
supports_fp64 = "cl_khr_fp64" in dev.extensions


# create GPUCompiler objects
target = SPIRVCompilerTarget(; supports_fp16, supports_fp64, version = v"1.2", kwargs...)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we assert here?

params = OpenCLCompilerParams()
Expand Down
Loading