Skip to content

Conversation

@vchuravy
Copy link
Member

@vchuravy vchuravy commented Nov 3, 2025

As observed in #652 these kernels behave differently on 1.11+

@giordano notes on Slack that this also resolves an issue he has observed with https://github.com/CliMA/Oceananigans.jl/blob/4265addd082f0462dfd4fc7114b89efa2a420ece/src/Models/NonhydrostaticModels/update_hydrostatic_pressure.jl#L12-L20

@vchuravy vchuravy marked this pull request as ready for review November 3, 2025 16:54
@github-actions

This comment was marked as off-topic.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.85%. Comparing base (b525d6b) to head (218abb9).
⚠️ Report is 5 commits behind head on release-0.9.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9     #653      +/-   ##
===============================================
+ Coverage        71.79%   71.85%   +0.06%     
===============================================
  Files               14       14              
  Lines              904      906       +2     
===============================================
+ Hits               649      651       +2     
  Misses             255      255              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vchuravy
Copy link
Member Author

vchuravy commented Nov 3, 2025

So the core of the issue is that :aliasscope seems to be causing a miss-compilation on 1.11+

I haven't been able to root-cause this for Julia itself. But since it occurs on the CPU backend this is likely a bug in either LLVM or Julia.

I see two options:

  1. Disable aliascope and thus @Const handling everywhere
  2. Disable it only on 1.11/1.12
  3. Only enable it when there is an actual @Const

@vchuravy vchuravy merged commit 76a35d8 into release-0.9 Nov 3, 2025
38 of 39 checks passed
@vchuravy vchuravy deleted the vc/accumulate branch November 3, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants