Skip to content

Commit 2bf7e24

Browse files
Link to issue instead of embedding (not minimal) MWE
1 parent 5af28d2 commit 2bf7e24

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/device/intrinsics/math.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ end
352352
@device_override Base.min(x::Int8, y::Int8) = ccall("extern air.min.s.i8", llvmcall, Int8, (Int8, Int8), x, y)
353353
@device_override Base.min(x::UInt8, y::UInt8) = ccall("extern air.min.u.i8", llvmcall, UInt8, (UInt8, UInt8), x, y)
354354

355-
# XXX: Breaks mul! when uncommented. MWE: using Revise, Metal;A, x = mtl(rand(Int32, 4, 4)), mtl(rand(Int32, 4)); A*x
355+
# XXX: Breaks code when uncommented. https://github.com/JuliaGPU/Metal.jl/issues/547
356356
# @device_override Base.max(x::Int64, y::Int64) = ccall("extern air.max.s.i64", llvmcall, Int64, (Int64, Int64), x, y)
357357
@device_override Base.max(x::UInt64, y::UInt64) = ccall("extern air.max.u.i64", llvmcall, UInt64, (UInt64, UInt64), x, y)
358358
@device_override Base.max(x::Int32, y::Int32) = ccall("extern air.max.s.i32", llvmcall, Int32, (Int32, Int32), x, y)

0 commit comments

Comments
 (0)