Skip to content

Commit 4533b56

Browse files
Unexport some high-level MPS functionality from MPS (#400)
1 parent a07675d commit 4533b56

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

lib/mps/images.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,7 @@ function MPSImageBox(dev, kernelWidth, kernelHeight)
7373
end
7474

7575

76-
## high-level blurring functionality
77-
78-
export blur, gaussianblur, boxblur
76+
## high-level blurring functionality. Interface subject to change
7977

8078
function blur(image, kernel; pixelFormat=MTL.MTLPixelFormatRGBA8Unorm)
8179
res = copy(image)

lib/mps/matrix.jl

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ end
242242

243243
## topk
244244

245-
export MPSMatrixFindTopK, encode!, topk, topk!
245+
export MPSMatrixFindTopK, encode!
246246

247247
@objcwrapper immutable=false MPSMatrixFindTopK <: MPSMatrixUnaryKernel
248248

@@ -270,7 +270,7 @@ function encode!(cmdbuf::MTLCommandBuffer, kernel::MPSMatrixFindTopK, inputMatri
270270
end
271271

272272
"""
273-
topk!(A::MtlMatrix{T}, I::MtlMatrix{Int32}, V::MtlMatrix{T}, k)
273+
MPS.topk!(A::MtlMatrix{T}, I::MtlMatrix{Int32}, V::MtlMatrix{T}, k)
274274
where {T<:MtlFloat}
275275
276276
Compute the top `k` values and their corresponding indices column-wise in a matrix `A`.
@@ -281,6 +281,9 @@ Return the indices in `I` and the values in `V`.
281281
Uses `MPSMatrixFindTopK`.
282282
283283
See also: [`topk`](@ref).
284+
285+
!!! warn
286+
This interface is experimental, and might change without warning.
284287
"""
285288
function topk!(A::MtlMatrix{T}, I::MtlMatrix{UInt32}, V::MtlMatrix{T}, k) where {T<:MtlFloat}
286289
size(I,1) >= k || throw(ArgumentError("Matrix 'I' must be large enough for k rows"))
@@ -311,7 +314,7 @@ end
311314
end
312315

313316
"""
314-
topk(A::MtlMatrix{T}, k) where {T<:MtlFloat}
317+
MPS.topk(A::MtlMatrix{T}, k) where {T<:MtlFloat}
315318
316319
Compute the top `k` values and their corresponding indices column-wise in a matrix `A`.
317320
Return the indices in `I` and the values in `V`.
@@ -321,6 +324,9 @@ Return the indices in `I` and the values in `V`.
321324
Uses `MPSMatrixFindTopK`.
322325
323326
See also: [`topk!`](@ref).
327+
328+
!!! warn
329+
This interface is experimental, and might change without warning.
324330
"""
325331
function topk(A::MtlMatrix{T,S}, k) where {T<:MtlFloat,S}
326332
s = (k,size(A,2))

0 commit comments

Comments
 (0)