Skip to content

Commit 5628d43

Browse files
authored
Allow initialisation of MTLSize with tuples of different integer types (#425)
1 parent e3d9b32 commit 5628d43

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

lib/mtl/size.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ struct MTLSize
1111
end
1212

1313
# convenience constructors from tuple inputs
14-
MTLSize(dims::NTuple{1,<:Integer}) = MTLSize(dims[1], 1, 1)
15-
MTLSize(dims::NTuple{2,<:Integer}) = MTLSize(dims[1], dims[2], 1)
16-
MTLSize(dims::NTuple{3,<:Integer}) = MTLSize(dims[1], dims[2], dims[3])
14+
MTLSize(dims::NTuple{1,Integer}) = MTLSize(dims[1], 1, 1)
15+
MTLSize(dims::NTuple{2,Integer}) = MTLSize(dims[1], dims[2], 1)
16+
MTLSize(dims::NTuple{3,Integer}) = MTLSize(dims[1], dims[2], dims[3])
1717

1818

1919
## origin

test/execution.jl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,17 @@ dummy() = return
1313
@metal threads dummy()
1414
@metal threads=1 dummy()
1515
@metal threads=(1,1) dummy()
16+
@metal threads=(Int32(1),Int64(1)) dummy()
1617
@metal threads=(1,1,1) dummy()
18+
@metal threads=(Int8(1),Int32(1),1) dummy()
1719

1820
groups = 1
1921
@metal groups dummy()
2022
@metal groups=1 dummy()
2123
@metal groups=(1,1) dummy()
24+
@metal groups=(Int32(1),Int64(1)) dummy()
2225
@metal groups=(1,1,1) dummy()
26+
@metal groups=(Int8(1),Int32(1),1) dummy()
2327

2428
@metal macos=Metal.macos_version() dummy()
2529
@metal metal=Metal.metal_support() dummy()

0 commit comments

Comments
 (0)