Skip to content

Commit 6ecb909

Browse files
authored
Simplify benchmark runner and pipelines (#494)
[only benchmarks]
1 parent 634cec7 commit 6ecb909

File tree

3 files changed

+9
-24
lines changed

3 files changed

+9
-24
lines changed

.buildkite/pipeline.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,6 @@ steps:
156156
if: |
157157
!build.pull_request.repository.fork &&
158158
(build.message =~ /\[only benchmarks\]/ ||
159-
build.message !~ /\[only/ && !build.pull_request.draft &&
160-
build.message !~ /\[skip benchmarks\]/)
159+
build.message !~ /\[only/ && !build.pull_request.draft &&
160+
build.message !~ /\[skip benchmarks\]/)
161161
timeout_in_minutes: 30

.github/workflows/Benchmark.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,13 @@ on:
3131

3232
jobs:
3333
benchmark:
34-
if: ${{ (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && (contains(github.event.head_commit.message, '[only benchmarks]') || !contains(github.event.head_commit.message, '[only') && !contains(github.event.head_commit.message, '[skip benchmarks]') && github.event.pull_request.draft == false) }}
34+
if: |
35+
(github.event_name != 'pull_request' ||
36+
github.event.pull_request.head.repo.full_name == github.repository) &&
37+
(contains(github.event.head_commit.message, '[only benchmarks]') ||
38+
!contains(github.event.head_commit.message, '[only') &&
39+
!contains(github.event.head_commit.message, '[skip benchmarks]') &&
40+
github.event.pull_request.draft == false)
3541
runs-on: ubuntu-latest
3642
steps:
3743
- uses: actions/checkout@v4

perf/runbenchmarks.jl

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ latency_results = include("latency.jl")
2727

2828
SUITE = BenchmarkGroup()
2929

30-
# NOTE: don't use spaces in benchmark names (tobami/codespeed#256)
31-
3230
include("metal.jl")
3331
include("kernel.jl")
3432
include("array.jl")
@@ -58,24 +56,5 @@ integration_results["metaldevrt"] = include("metaldevrt.jl")
5856
results["latency"] = latency_results
5957
results["integration"] = integration_results
6058

61-
println(results)
62-
63-
64-
## comparison
65-
6659
# write out the results
6760
BenchmarkTools.save("benchmarkresults.json", median(results))
68-
69-
# compare against previous results
70-
# TODO: store these results so that we can compare when benchmarking PRs
71-
reference_path = joinpath(@__DIR__, "reference.json")
72-
if ispath(reference_path)
73-
reference = BenchmarkTools.load(reference_path)[1]
74-
comparison = judge(minimum(results), minimum(reference))
75-
76-
println("Improvements:")
77-
println(improvements(comparison))
78-
79-
println("Regressions:")
80-
println(regressions(comparison))
81-
end

0 commit comments

Comments
 (0)