Clean up test imports (#584)

christiangnrd · web-flow · commit 987264c3befd · 2025-04-20T23:59:25.000-03:00
* Fix MPSGraphRandomOpDescriptor tests

* Clean up test imports

* Whitespace consistency

* Capitalization consistency

* `end` clarifcation comments
diff --git a/test/device/intrinsics/atomics.jl b/test/device/intrinsics/atomics.jl
@@ -1,5 +1,3 @@
-using Random
-
 @testset "atomics" begin
 
 n = 128 # NOTE: also hard-coded in MtlThreadGroupArray constructors
diff --git a/test/device/intrinsics/math.jl b/test/device/intrinsics/math.jl
@@ -1,5 +1,4 @@
 using Metal: metal_support
-using Random
 using SpecialFunctions
 
 ############################################################################################
diff --git a/test/device/intrinsics/simd.jl b/test/device/intrinsics/simd.jl
@@ -1,5 +1,3 @@
-using Random
-
 @testset "simd intrinsics" begin
 
 @testset "$f($typ)" for typ in [Float32, Float16, Int32, UInt32, Int16, UInt16, Int8, UInt8], (f,res_idx) in [(simd_shuffle_down, 1), (simd_shuffle_up, 32)]
diff --git a/test/device/intrinsics/synchronization.jl b/test/device/intrinsics/synchronization.jl
@@ -1,4 +1,3 @@
-using Random
 @testset "synchronization" begin
     # host/device synchronization
     let
diff --git a/test/mps/linalg.jl b/test/mps/linalg.jl
@@ -1,5 +1,3 @@
-using LinearAlgebra
-
 if MPS.is_supported(device())
 
 @testset "mixed-precision matrix matrix multiplication" begin
diff --git a/test/mps/ndarray.jl b/test/mps/ndarray.jl
@@ -1,7 +1,6 @@
 #
 # matrix descriptor
 #
-using Metal
 using .MPS: MPSNDArrayDescriptor, MPSDataType, lengthOfDimension, descriptor, resourceSize
 @static if Metal.macos_version() >= v"15"
     using .MPS: userBuffer
diff --git a/test/mpsgraphs/core.jl b/test/mpsgraphs/core.jl
@@ -1,4 +1,3 @@
-
 if MPS.is_supported(device())
 
 using .MPS: MPSShape
diff --git a/test/mpsgraphs/linalg.jl b/test/mpsgraphs/linalg.jl
@@ -1,6 +1,3 @@
-using LinearAlgebra
-
-
 if MPS.is_supported(device())
 
 @testset "mixed-precision matrix matrix multiplication" begin
diff --git a/test/mpsgraphs/random.jl b/test/mpsgraphs/random.jl
@@ -1,5 +1,3 @@
-using BFloat16s
-
 if MPS.is_supported(device())
 
 using .MPSGraphs: MPSGraphRandomOpDescriptor, MPSGraphRandomDistributionNormal, MPSGraphRandomDistributionTruncatedNormal, MPSGraphRandomDistributionUniform
@@ -18,7 +16,7 @@ using .MPSGraphs: MPSGraphRandomOpDescriptor, MPSGraphRandomDistributionNormal,
                       (MPSGraphRandomDistributionUniform, Float16),
                       (MPSGraphRandomDistributionUniform, BFloat16),
                       ]
-        @test MPSGraphRandomOpDescriptor(MPSGraphRandomDistributionNormal, Float32) isa MPSGraphRandomOpDescriptor
+        @test MPSGraphRandomOpDescriptor(dist, T) isa MPSGraphRandomOpDescriptor
     end
 end
 
diff --git a/test/mtl/metal.jl b/test/mtl/metal.jl
@@ -491,6 +491,6 @@ end
 
 # TODO: continue adding tests
 
-end
+end # @autoreleasepool begin
 
-end
+end # @testset "MTL" begin
diff --git a/test/mtl/size.jl b/test/mtl/size.jl
@@ -1,4 +1,3 @@
-
 @testset "size" begin
     dim1 = rand(UInt64)
     dim2 = rand(UInt64)
diff --git a/test/profiling.jl b/test/profiling.jl
@@ -30,8 +30,8 @@ cd(tmpdir) do
     @test isdir("julia_1.trace")
 end
 
-end
-end
-end
+end # cd(tmpdir) do
+end # mktempdir() do tmpdir
+end # if run_tests
 
 end
diff --git a/test/setup.jl b/test/setup.jl
@@ -1,4 +1,4 @@
-using Distributed, Test, Metal, Adapt, ObjectiveC, ObjectiveC.Foundation
+using Distributed, Test, Metal, Adapt, ObjectiveC, ObjectiveC.Foundation, BFloat16s
 
 # GPUArrays has a testsuite that isn't part of the main package.
 # Include it directly.
diff --git a/test/version.jl b/test/version.jl
@@ -1,4 +1,4 @@
-@testset "Version" begin
+@testset "version" begin
 
 @test Metal.darwin_version() isa VersionNumber
 @test Metal.macos_version() isa VersionNumber
@@ -8,4 +8,4 @@
 @test Metal.air_support() isa VersionNumber
 @test Metal.metal_support() isa VersionNumber
 
-end # testset "Version"
+end # testset "version"

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-using Random`
`2`		`-`
`3`	`1`	`@testset "atomics" begin`
`4`	`2`
`5`	`3`	`n = 128 # NOTE: also hard-coded in MtlThreadGroupArray constructors`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`using Metal: metal_support`
`2`		`-using Random`
`3`	`2`	`using SpecialFunctions`
`4`	`3`
`5`	`4`	`############################################################################################`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-using Random`
`2`		`-`
`3`	`1`	`@testset "simd intrinsics" begin`
`4`	`2`
`5`	`3`	`@testset "$f($typ)" for typ in [Float32, Float16, Int32, UInt32, Int16, UInt16, Int8, UInt8], (f,res_idx) in [(simd_shuffle_down, 1), (simd_shuffle_up, 32)]`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-using Random`
`2`	`1`	`@testset "synchronization" begin`
`3`	`2`	`# host/device synchronization`
`4`	`3`	`let`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-using LinearAlgebra`
`2`		`-`
`3`	`1`	`if MPS.is_supported(device())`
`4`	`2`
`5`	`3`	`@testset "mixed-precision matrix matrix multiplication" begin`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`#`
`2`	`2`	`# matrix descriptor`
`3`	`3`	`#`
`4`		`-using Metal`
`5`	`4`	`using .MPS: MPSNDArrayDescriptor, MPSDataType, lengthOfDimension, descriptor, resourceSize`
`6`	`5`	`@static if Metal.macos_version() >= v"15"`
`7`	`6`	`using .MPS: userBuffer`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-`
`2`	`1`	`if MPS.is_supported(device())`
`3`	`2`
`4`	`3`	`using .MPS: MPSShape`