Skip to content

Commit e1cb12e

Browse files
Fix tests for macOS 13 (#591)
1 parent 145dc33 commit e1cb12e

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

test/linalg.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,21 +33,21 @@ if MPS.is_supported(device())
3333
# :auto
3434
@test test_matmul(Int32, Int32; vec_b) # fallback to GPUArrays
3535
@test test_matmul(Int8, Float32; vec_b) # should use MPS
36-
@test test_matmul(Float16, Float32; vec_b) # should use MPSGraph on M1/M2
36+
Metal.macos_version() >= v"14" && @test test_matmul(Float16, Float32; vec_b) # should use MPSGraph on M1/M2
3737

3838
# :MPS
3939
mpsInT = vec_b ? Float32 : Int16
4040
@test test_matmul(mpsInT, Float32; vec_b, alg=:MPS)
41-
@test test_matmul(Float16, Float32; vec_b, alg=:MPS)
41+
Metal.macos_version() >= v"14" && @test test_matmul(Float16, Float32; vec_b, alg=:MPS)
4242

4343
# :MPSGraph
4444
@test test_matmul(Int8, Float32; vec_b, alg=:MPSGraph)
45-
@test test_matmul(Float16, Float32; vec_b, alg=:MPSGraph)
45+
Metal.macos_version() >= v"14" && @test test_matmul(Float16, Float32; vec_b, alg=:MPSGraph)
4646

4747
# :GPUArrays
4848
@test test_matmul(Int32, Int32; vec_b, alg=:GPUArrays)
4949
@test test_matmul(Int8, Float32; vec_b, alg=:GPUArrays)
50-
@test test_matmul(Float16, Float32; vec_b, alg=:GPUArrays)
50+
Metal.macos_version() >= v"14" && @test test_matmul(Float16, Float32; vec_b, alg=:GPUArrays)
5151
end
5252
end
5353
end

test/mpsgraphs/random.jl

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,24 @@ using .MPSGraphs: MPSGraphRandomOpDescriptor, MPSGraphRandomDistributionNormal,
44
@testset "MPSGraph random" begin
55
# determined by looking at the error message when trying to construct
66
# an invalid distribution/type combination
7-
for (dist, T) in [(MPSGraphRandomDistributionNormal, Float32),
7+
OP_TYPES = [(MPSGraphRandomDistributionNormal, Float32),
88
(MPSGraphRandomDistributionNormal, Float16),
9-
(MPSGraphRandomDistributionNormal, BFloat16),
109
(MPSGraphRandomDistributionTruncatedNormal, Float32),
1110
(MPSGraphRandomDistributionTruncatedNormal, Float16),
12-
(MPSGraphRandomDistributionTruncatedNormal, BFloat16),
1311
(MPSGraphRandomDistributionUniform, Int64),
1412
(MPSGraphRandomDistributionUniform, Int32),
1513
(MPSGraphRandomDistributionUniform, Float32),
1614
(MPSGraphRandomDistributionUniform, Float16),
17-
(MPSGraphRandomDistributionUniform, BFloat16),
1815
]
16+
17+
if Metal.macos_version() >= v"14"
18+
append!(OP_TYPES, [(MPSGraphRandomDistributionNormal, BFloat16),
19+
(MPSGraphRandomDistributionTruncatedNormal, BFloat16),
20+
(MPSGraphRandomDistributionUniform, BFloat16),]
21+
)
22+
end
23+
24+
for (dist, T) in OP_TYPES
1925
@test MPSGraphRandomOpDescriptor(dist, T) isa MPSGraphRandomOpDescriptor
2026
end
2127
end

0 commit comments

Comments
 (0)