Skip to content

Commit ef12be1

Browse files
committed
Only one eval per sample in "construct" benchmark
Seems to solve some hangs on the CI runners
1 parent 157e5c6 commit ef12be1

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.buildkite/pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,4 +151,4 @@ steps:
151151
build.message =~ /\[only benchmarks\]/ ||
152152
build.message !~ /\[only/ && !build.pull_request.draft &&
153153
build.message !~ /\[skip benchmarks\]/
154-
timeout_in_minutes: 45
154+
timeout_in_minutes: 30

perf/array.jl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,10 @@ gpu_vec_ints = reshape(gpu_mat_ints, length(gpu_mat_ints))
6565
# group["1d_inplace"] = @benchmarkable Metal.@sync reverse!($gpu_vec)
6666
# group["2d_inplace"] = @benchmarkable Metal.@sync reverse!($gpu_mat; dims=1)
6767
# end
68-
group["construct"] = @benchmarkable MtlArray{Int,1}(undef, 1)
68+
69+
# 'evals=1' added to prevent hang when running benchmarks of CI
70+
# TODO: Investigate cause and properly fix.
71+
group["construct"] = @benchmarkable MtlArray{Int,1}(undef, 1) evals=1
6972

7073
group["broadcast"] = @benchmarkable Metal.@sync $gpu_mat .= 0f0
7174

0 commit comments

Comments
 (0)