Feedback

Author: christiangnrd

lib/mtl/capture.jl

@@ -150,8 +150,6 @@ Stop GPU frame capture.
 """
 function stopCapture(manager::MTLCaptureManager=MTLCaptureManager())
     @objc [manager::id{MTLCaptureManager} stopCapture]::Nothing
-    while manager.isCapturing
-    end
 end
 
 function supports_destination(manager::MTLCaptureManager, destination::MTLCaptureDestination)

src/utilities.jl

@@ -143,10 +143,10 @@ function captured(f; dest=MTL.MTLCaptureDestinationGPUTraceDocument,
         beginScope(scope)
         f()
         endScope(scope)
-        synchronize()
     finally
         @info "GPU frame capture saved to $folder; open the resulting trace in Xcode"
         stopCapture()
+        synchronize()
     end
 end
 

test/capturing.jl

@@ -68,6 +68,7 @@ startCapture(manager, desc)
 @test_throws ErrorException startCapture(manager, desc)
 Metal.@sync @metal threads=4 tester(bufferA)
 stopCapture(manager)
+synchronize()
 @test manager.isCapturing == false
 @test isdir(path)
 release(new_scope)