Skip to content

Commit 5ca229f

Browse files
authored
Type fixes for Windows. (#270)
1 parent 0e98d7a commit 5ca229f

File tree

5 files changed

+21
-18
lines changed

5 files changed

+21
-18
lines changed

lib/cl/device.jl

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -54,27 +54,27 @@ end
5454
return Int(scalar[])
5555
end
5656
if s === :vendor_id
57-
return get_scalar(CL_DEVICE_VENDOR_ID, Cuint)
57+
return get_scalar(CL_DEVICE_VENDOR_ID, cl_uint)
5858
elseif s === :max_compute_units
59-
return get_scalar(CL_DEVICE_MAX_COMPUTE_UNITS, Cuint)
59+
return get_scalar(CL_DEVICE_MAX_COMPUTE_UNITS, cl_uint)
6060
elseif s === :max_work_item_dims
61-
return get_scalar(CL_DEVICE_MAX_WORK_ITEM_DIMENSIONS, Cuint)
61+
return get_scalar(CL_DEVICE_MAX_WORK_ITEM_DIMENSIONS, cl_uint)
6262
elseif s === :max_clock_frequency
63-
return get_scalar(CL_DEVICE_MAX_CLOCK_FREQUENCY, Cuint)
63+
return get_scalar(CL_DEVICE_MAX_CLOCK_FREQUENCY, cl_uint)
6464
elseif s === :address_bits
65-
return get_scalar(CL_DEVICE_ADDRESS_BITS, Cuint)
65+
return get_scalar(CL_DEVICE_ADDRESS_BITS, cl_uint)
6666
elseif s === :max_read_image_args
67-
return get_scalar(CL_DEVICE_MAX_READ_IMAGE_ARGS, Cuint)
67+
return get_scalar(CL_DEVICE_MAX_READ_IMAGE_ARGS, cl_uint)
6868
elseif s === :max_write_image_args
69-
return get_scalar(CL_DEVICE_MAX_WRITE_IMAGE_ARGS, Cuint)
69+
return get_scalar(CL_DEVICE_MAX_WRITE_IMAGE_ARGS, cl_uint)
7070
elseif s === :global_mem_size
71-
return get_scalar(CL_DEVICE_GLOBAL_MEM_SIZE, Culong)
71+
return get_scalar(CL_DEVICE_GLOBAL_MEM_SIZE, cl_ulong)
7272
elseif s === :max_mem_alloc_size
73-
return get_scalar(CL_DEVICE_MAX_MEM_ALLOC_SIZE, Culong)
73+
return get_scalar(CL_DEVICE_MAX_MEM_ALLOC_SIZE, cl_ulong)
7474
elseif s === :max_const_buffer_size
75-
return get_scalar(CL_DEVICE_MAX_CONSTANT_BUFFER_SIZE, Culong)
75+
return get_scalar(CL_DEVICE_MAX_CONSTANT_BUFFER_SIZE, cl_ulong)
7676
elseif s === :local_mem_size
77-
return get_scalar(CL_DEVICE_LOCAL_MEM_SIZE, Culong)
77+
return get_scalar(CL_DEVICE_LOCAL_MEM_SIZE, cl_ulong)
7878
elseif s === :max_work_group_size
7979
return get_scalar(CL_DEVICE_MAX_WORK_GROUP_SIZE, Csize_t)
8080
elseif s === :max_parameter_size

lib/cl/event.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ function Base.getproperty(evt::AbstractEvent, s::Symbol)
220220
function profiling_info(evt::AbstractEvent, profile_info)
221221
time = Ref{Clong}(0)
222222
try
223-
clGetEventProfilingInfo(evt, profile_info, sizeof(Culong), time, C_NULL)
223+
clGetEventProfilingInfo(evt, profile_info, sizeof(cl_ulong), time, C_NULL)
224224
catch err
225225
if isa(err, CLError) && err.code == CL_PROFILING_INFO_NOT_AVAILABLE
226226
if evt.status != :complete

lib/cl/kernel.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,9 +319,9 @@ function Base.getproperty(ki::KernelWorkGroupInfo, s::Symbol)
319319
elseif s == :compile_size
320320
Int.(get(CL_KERNEL_COMPILE_WORK_GROUP_SIZE, NTuple{3, Csize_t}))
321321
elseif s == :local_mem_size
322-
Int(get(CL_KERNEL_LOCAL_MEM_SIZE, Culong))
322+
Int(get(CL_KERNEL_LOCAL_MEM_SIZE, cl_ulong))
323323
elseif s == :private_mem_size
324-
Int(get(CL_KERNEL_PRIVATE_MEM_SIZE, Culong))
324+
Int(get(CL_KERNEL_PRIVATE_MEM_SIZE, cl_ulong))
325325
elseif s == :prefered_size_multiple
326326
Int(get(CL_KERNEL_PREFERRED_WORK_GROUP_SIZE_MULTIPLE, Csize_t))
327327
else

lib/cl/libopencl.jl

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,12 @@ function check(f)
1717
return
1818
end
1919

20-
const __darwin_intptr_t = Clong
21-
22-
const intptr_t = __darwin_intptr_t
20+
# TODO: add this to the generator
21+
const intptr_t = if sizeof(Ptr{Cvoid}) == 8
22+
Int64
23+
else
24+
Int32
25+
end
2326

2427
const cl_int = Int32
2528

test/kernel.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@
132132
structkernel = cl.Kernel(prg, "structest")
133133
out = CLArray{Float32}(undef, 2)
134134
bstruct = (1, Int32(4))
135-
clcall(structkernel, Tuple{Ptr{Float32}, Tuple{Clong, Cint}}, out, bstruct)
135+
clcall(structkernel, Tuple{Ptr{Float32}, Tuple{Int64, Cint}}, out, bstruct)
136136
@test Array(out) == [1f0, 4f0]
137137
end
138138

0 commit comments

Comments
 (0)