Skip to content

Update jupyter notebooks#291

Merged
maleadt merged 2 commits intoJuliaGPU:masterfrom
blegat:ipynb
Mar 25, 2025
Merged

Update jupyter notebooks#291
maleadt merged 2 commits intoJuliaGPU:masterfrom
blegat:ipynb

Conversation

@blegat
Copy link
Contributor

@blegat blegat commented Mar 21, 2025

I switched from PyPlot to CairoMakie to remove the dependency on python as it sometimes cause installation issues.
Additionally,

  • for mandelbrot, I removed the build_q because there was already a one-liner that could be slightly tweaked to compute exactly the same thing in the previous cell.
  • for Transpose, I fixed the error MethodError: no method matching unsafe_convert(::Type{Ptr{Float32}}, ::OpenCL.cl.LocalMem{Float32}).

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.96%. Comparing base (1943f1c) to head (18eae31).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   72.96%   72.96%           
=======================================
  Files          12       12           
  Lines         614      614           
=======================================
  Hits          448      448           
  Misses        166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/examples/hands_on_opencl/ex08/matmul.jl b/examples/hands_on_opencl/ex08/matmul.jl
index c03e8bc..89da753 100644
--- a/examples/hands_on_opencl/ex08/matmul.jl
+++ b/examples/hands_on_opencl/ex08/matmul.jl
@@ -151,7 +151,7 @@ else
 
 @info("=== OpenCL, matrix mult, C row, priv A, B, cols loc, order $Ndim ====")
 
-ORDER = 2
+    ORDER = 2
 
 for i in 1:COUNT
     fill!(h_C, 0.0)
diff --git a/examples/hands_on_opencl/ex09/pi_ocl.jl b/examples/hands_on_opencl/ex09/pi_ocl.jl
index cef4977..bc27dc2 100644
--- a/examples/hands_on_opencl/ex09/pi_ocl.jl
+++ b/examples/hands_on_opencl/ex09/pi_ocl.jl
@@ -18,7 +18,7 @@ src_dir = dirname(Base.source_path())
 
 #
 # Some constant values
-INSTEPS = 512*512*512
+INSTEPS = 512 * 512 * 512
 ITERS = 262144
 
 # Set some default values:
diff --git a/examples/performance.jl b/examples/performance.jl
index e2f4ab4..dd69865 100644
--- a/examples/performance.jl
+++ b/examples/performance.jl
@@ -107,5 +107,5 @@ end
 # ex. N_WORKERS = 1 is non parallel execution on the gpu
 
 const N_DATA_PTS = Int(2^2) # ~8 million
-const N_WORKERS  = Int(2^2)
+const N_WORKERS = Int(2^2)
 cl_performance(N_DATA_PTS, N_WORKERS)

@blegat blegat mentioned this pull request Mar 21, 2025
@maleadt maleadt merged commit d154022 into JuliaGPU:master Mar 25, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants