Merged
Conversation
blegat
commented
Mar 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
=======================================
Coverage 72.96% 72.96%
=======================================
Files 12 12
Lines 614 614
=======================================
Hits 448 448
Misses 166 166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/examples/hands_on_opencl/ex08/matmul.jl b/examples/hands_on_opencl/ex08/matmul.jl
index c03e8bc..89da753 100644
--- a/examples/hands_on_opencl/ex08/matmul.jl
+++ b/examples/hands_on_opencl/ex08/matmul.jl
@@ -151,7 +151,7 @@ else
@info("=== OpenCL, matrix mult, C row, priv A, B, cols loc, order $Ndim ====")
-ORDER = 2
+ ORDER = 2
for i in 1:COUNT
fill!(h_C, 0.0)
diff --git a/examples/hands_on_opencl/ex09/pi_ocl.jl b/examples/hands_on_opencl/ex09/pi_ocl.jl
index cef4977..bc27dc2 100644
--- a/examples/hands_on_opencl/ex09/pi_ocl.jl
+++ b/examples/hands_on_opencl/ex09/pi_ocl.jl
@@ -18,7 +18,7 @@ src_dir = dirname(Base.source_path())
#
# Some constant values
-INSTEPS = 512*512*512
+INSTEPS = 512 * 512 * 512
ITERS = 262144
# Set some default values:
diff --git a/examples/performance.jl b/examples/performance.jl
index e2f4ab4..dd69865 100644
--- a/examples/performance.jl
+++ b/examples/performance.jl
@@ -107,5 +107,5 @@ end
# ex. N_WORKERS = 1 is non parallel execution on the gpu
const N_DATA_PTS = Int(2^2) # ~8 million
-const N_WORKERS = Int(2^2)
+const N_WORKERS = Int(2^2)
cl_performance(N_DATA_PTS, N_WORKERS) |
Merged
maleadt
reviewed
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I switched from
PyPlottoCairoMakieto remove the dependency on python as it sometimes cause installation issues.Additionally,
mandelbrot, I removed thebuild_qbecause there was already a one-liner that could be slightly tweaked to compute exactly the same thing in the previous cell.Transpose, I fixed the errorMethodError: no method matching unsafe_convert(::Type{Ptr{Float32}}, ::OpenCL.cl.LocalMem{Float32}).