Merged
Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/examples/hands_on_opencl/ex08/matmul.jl b/examples/hands_on_opencl/ex08/matmul.jl
index 6e7513e..80d31c0 100644
--- a/examples/hands_on_opencl/ex08/matmul.jl
+++ b/examples/hands_on_opencl/ex08/matmul.jl
@@ -103,7 +103,8 @@ mmul = cl.Kernel(prg, "mmul")
for i in 1:COUNT
fill!(h_C, 0.0)
cl.queue!(:profile) do
- evt = clcall(mmul, Tuple{Int32, Int32, Int32, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}},
+ evt = clcall(
+ mmul, Tuple{Int32, Int32, Int32, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}},
Mdim, Ndim, Pdim, d_a, d_b, d_c; global_size=(Ndim, Mdim))
wait(evt)
@@ -127,7 +128,8 @@ mmul = cl.Kernel(prg, "mmul")
for i in 1:COUNT
fill!(h_C, 0.0)
cl.queue!(:profile) do
- evt = clcall(mmul, Tuple{Int32, Int32, Int32, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}},
+ evt = clcall(
+ mmul, Tuple{Int32, Int32, Int32, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}},
Mdim, Ndim, Pdim, d_a, d_b, d_c; global_size=Ndim, local_size=(ORDER ÷ 16))
wait(evt)
@@ -159,7 +161,8 @@ for i in 1:COUNT
global_size = (Ndim,)
local_size = (div(ORDER, 16),)
- evt = clcall(mmul, Tuple{Int32, Int32, Int32, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}},
+ evt = clcall(
+ mmul, Tuple{Int32, Int32, Int32, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}},
Mdim, Ndim, Pdim, d_a, d_b, d_c, localmem; global_size, local_size)
wait(evt)
@@ -190,7 +193,8 @@ for i in 1:COUNT
localmem1 = cl.LocalMem(Float32, blocksize^2)
localmem2 = cl.LocalMem(Float32, blocksize^2)
cl.queue!(:profile) do
- evt = clcall(mmul, Tuple{Int32, Int32, Int32, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}},
+ evt = clcall(
+ mmul, Tuple{Int32, Int32, Int32, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}, CLPtr{Float32}},
Mdim, Ndim, Pdim, d_a, d_b, d_c, localmem1, localmem2; global_size=Ndim, local_size=(ORDER ÷ 16))
wait(evt)
diff --git a/examples/hands_on_opencl/ex09/pi_ocl.jl b/examples/hands_on_opencl/ex09/pi_ocl.jl
index 86ab9c6..c36da29 100644
--- a/examples/hands_on_opencl/ex09/pi_ocl.jl
+++ b/examples/hands_on_opencl/ex09/pi_ocl.jl
@@ -68,7 +68,8 @@ global_size = (nwork_groups * work_group_size,)
local_size = (work_group_size,)
localmem = cl.LocalMem(Float32, work_group_size)
-clcall(pi_kernel, Tuple{Int32, Float32, CLPtr{Float32}, CLPtr{Float32}},
+clcall(
+ pi_kernel, Tuple{Int32, Float32, CLPtr{Float32}, CLPtr{Float32}},
niters, step_size, localmem, d_partial_sums; global_size, local_size)
cl.copy!(h_psum, d_partial_sums)
diff --git a/examples/hands_on_opencl/exA/pi_vocl.jl b/examples/hands_on_opencl/exA/pi_vocl.jl
index 9726d26..fc81301 100644
--- a/examples/hands_on_opencl/exA/pi_vocl.jl
+++ b/examples/hands_on_opencl/exA/pi_vocl.jl
@@ -107,7 +107,8 @@ global_size = (nwork_groups * work_group_size,)
local_size = (work_group_size,)
localmem = cl.LocalMem(Float32, work_group_size)
-clcall(pi_kernel, Tuple{Int32, Float32, CLPtr{Float32}, CLPtr{Float32}},
+clcall(
+ pi_kernel, Tuple{Int32, Float32, CLPtr{Float32}, CLPtr{Float32}},
niters, step_size, localmem, d_partial_sums; global_size, local_size)
cl.copy!(h_psum, d_partial_sums) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #293 +/- ##
=======================================
Coverage 72.96% 72.96%
=======================================
Files 12 12
Lines 614 614
=======================================
Hits 448 448
Misses 166 166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maleadt
reviewed
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used
cl.LocalMemin #291 because I followed what was done in this exampleIf we follow your suggestion for the jupyter notebook then I guess we could also update it in the example to be consistent.