Skip to content

Add warning about using pocl_jll on top of script#295

Merged
maleadt merged 1 commit intoJuliaGPU:masterfrom
blegat:warn_pocl_jll
Mar 28, 2025
Merged

Add warning about using pocl_jll on top of script#295
maleadt merged 1 commit intoJuliaGPU:masterfrom
blegat:warn_pocl_jll

Conversation

@blegat
Copy link
Contributor

@blegat blegat commented Mar 28, 2025

This is a bit obvious from the perspective of a C library that is non interactive but the behavior may seem counter-intuitive from the Julia perspective.
I've checked through the OpenCL-ICD-Loader and there does not seem to be a way to force it to refresh the list so it seems opening a new Julia session is the right recommendation

@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.96%. Comparing base (d154022) to head (eddf69d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
- Coverage   73.12%   72.96%   -0.17%     
==========================================
  Files          12       12              
  Lines         614      614              
==========================================
- Hits          449      448       -1     
- Misses        165      166       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt
Copy link
Member

maleadt commented Mar 28, 2025

LGMT, thanks. It's a pity that the ICD works as statically as it does, I'd love to have an API to register new back-ends instead of the env var shenanigans we have to do now. Alas.

@maleadt maleadt merged commit 33309bf into JuliaGPU:master Mar 28, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants