Merged
Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/lib/support/liboneapi_support.jl b/lib/support/liboneapi_support.jl
index 5daba24..6db5fc8 100644
--- a/lib/support/liboneapi_support.jl
+++ b/lib/support/liboneapi_support.jl
@@ -205,8 +205,10 @@ mutable struct omatadd_descr end
const omatadd_descr_t = Ptr{omatadd_descr}
function onemkl_version(major, minor, patch)
- @ccall liboneapi_support.onemkl_version(major::Ptr{Int64}, minor::Ptr{Int64},
- patch::Ptr{Int64})::Cvoid
+ return @ccall liboneapi_support.onemkl_version(
+ major::Ptr{Int64}, minor::Ptr{Int64},
+ patch::Ptr{Int64}
+ )::Cvoid
end
function onemklHgemm_batch(device_queue, transa, transb, m, n, k, alpha, a, lda, b, ldb,
diff --git a/test/onemkl.jl b/test/onemkl.jl
index b75894c..7d88bf9 100644
--- a/test/onemkl.jl
+++ b/test/onemkl.jl
@@ -12,10 +12,10 @@ m = 20
n = 35
k = 13
-@testset "Version" begin
- version_onemkl = oneMKL.version()
- @test version_onemkl ≥ v"2025.2.0"
-end
+ @testset "Version" begin
+ version_onemkl = oneMKL.version()
+ @test version_onemkl ≥ v"2025.2.0"
+ end
############################################################################################
@testset "level 1" begin |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
==========================================
+ Coverage 79.70% 79.74% +0.04%
==========================================
Files 45 45
Lines 2818 2824 +6
==========================================
+ Hits 2246 2252 +6
Misses 572 572 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
michel2323
approved these changes
Sep 17, 2025
Member
No problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#525
@michel2323
I didn't updated
oneAPI.versioninfo(), can you do it after the PR?