Skip to content

Conversation

@willtebbutt
Copy link
Member

Summary

We deprecated dtc in favour of approx_log_evidence a while, but were still calling it in our test suite in a couple of places.

Proposed changes

Replace all calls to dtc with approx_log_evidence

See above

What alternatives have you considered?

None

Breaking changes

None

@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (58d858a) to head (dfc9496).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/util/TestUtils.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #418   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          11      11           
  Lines         381     381           
======================================
  Misses        381     381           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willtebbutt willtebbutt requested a review from theogf March 16, 2025 13:51
@willtebbutt willtebbutt merged commit 28319c5 into master Mar 16, 2025
12 checks passed
@willtebbutt willtebbutt deleted the wct/do-not-use-deprecated-behaviour branch March 16, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants