Skip to content

Conversation

@avik-pal
Copy link
Contributor

@yebai added some of my lux related changes here

k = SqExponentialKernel() FunctionTransform(x -> neural_transform(x, ps))
fx = AbstractGPs.FiniteGP(GP(k), x_train, noise_std^2)
_, loss_val, _, tstate = Training.single_train_step!(
AutoZygote(), update_kernel_and_loss, (), tstate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to keep changes as minimal as possible but this can also be switched to Mooncake

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.21%. Comparing base (cd5e927) to head (237f213).
⚠️ Report is 1 commits behind head on copilot/fix-426.

Additional details and impacted files
@@               Coverage Diff                @@
##           copilot/fix-426     #438   +/-   ##
================================================
  Coverage            96.21%   96.21%           
================================================
  Files                   12       12           
  Lines                  396      396           
================================================
  Hits                   381      381           
  Misses                  15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@avik-pal avik-pal force-pushed the ap/lux_improvements branch from 8b551a6 to 237f213 Compare August 29, 2025 01:12
@yebai yebai merged commit e966370 into JuliaGaussianProcesses:copilot/fix-426 Aug 29, 2025
10 checks passed
@yebai
Copy link
Contributor

yebai commented Aug 29, 2025

Thanks @avik-pal!

yebai added a commit that referenced this pull request Aug 29, 2025
* Initial plan

* Replace Flux with Lux in deep kernel learning example

Co-authored-by: yebai <[email protected]>

* Improve Lux implementation with proper parameter handling

Co-authored-by: yebai <[email protected]>

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix Literate.jl parsing issue in deep kernel learning example

Co-authored-by: yebai <[email protected]>

* Clean up comments in script.jl

* docs: use more of Lux official API for training and inference (#438)

* Update examples/2-deep-kernel-learning/script.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: yebai <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Avik Pal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants