Removed all deprecated methods and tests (#266)

Author: theogf

Project.toml

@@ -1,6 +1,6 @@
 name = "KernelFunctions"
 uuid = "ec8451be-7e33-11e9-00cf-bbf324bd1392"
-version = "0.8.26"
+version = "0.9.0"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

docs/src/userguide.md

@@ -28,7 +28,7 @@ For example, a squared exponential kernel is created by
     ```math
     k(x, x'; P) = \exp{\big(- (x - x')^\top P (x - x')\big)}
     ```
-    for a positive definite matrix $P = Q^\top Q$, is deprecated. Instead you can
+    for a positive definite matrix $P = Q^\top Q$, was removed in 0.9. Instead you can
     use a squared exponential kernel together with a [`LinearTransform`](@ref) of
     the inputs:
     ```julia

src/KernelFunctions.jl

@@ -1,18 +1,5 @@
 module KernelFunctions
 
-if !isfile(joinpath(@__DIR__, "update_v0.8.0"))
-    printstyled(
-        stdout,
-        """
-        WARNING: SqExponentialKernel changed convention in version 0.8.0.
-        This kernel now divides the squared distance by 2 to align with standard practice.
-        This warning will be removed in 0.9.0.
-        """;
-        color=Base.info_color(),
-    )
-    touch(joinpath(@__DIR__, "update_v0.8.0"))
-end
-
 export kernelmatrix, kernelmatrix!, kernelmatrix_diag, kernelmatrix_diag!
 export transform
 export duplicate, set! # Helpers
@@ -119,8 +106,6 @@ include("zygoterules.jl")
 
 include("test_utils.jl")
 
-include("deprecated.jl")
-
 function __init__()
     @require Kronecker = "2c470bb0-bcc8-11e8-3dad-c9649493f05e" begin
         include(joinpath("matrix", "kernelkroneckermat.jl"))

src/basekernels/piecewisepolynomial.jl

@@ -40,28 +40,8 @@ struct PiecewisePolynomialKernel{D,C<:Tuple} <: SimpleKernel
     end
 end
 
-# TODO: remove `maha` keyword argument in next breaking release
-function PiecewisePolynomialKernel(; v::Int=-1, degree::Int=0, maha=nothing, dim::Int=-1)
-    if v != -1
-        Base.depwarn(
-            "keyword argument `v` is deprecated, use `degree` instead",
-            :PiecewisePolynomialKernel,
-        )
-        degree = v
-    end
-
-    if maha !== nothing
-        Base.depwarn(
-            "keyword argument `maha` is deprecated, use a `LinearTransform` instead",
-            :PiecewisePolynomialKernel,
-        )
-        dim = size(maha, 1)
-        return transform(
-            PiecewisePolynomialKernel{degree}(dim), LinearTransform(cholesky(maha).U)
-        )
-    else
-        return PiecewisePolynomialKernel{degree}(dim)
-    end
+function PiecewisePolynomialKernel(; degree::Int=0, dim::Int=-1)
+    return PiecewisePolynomialKernel{degree}(dim)
 end
 
 piecewise_polynomial_coefficients(::Val{0}, ::Int) = (1,)

src/basekernels/polynomial.jl

@@ -56,15 +56,7 @@ struct PolynomialKernel{Tc<:Real} <: SimpleKernel
     end
 end
 
-function PolynomialKernel(; d::Real=-1, degree::Int=2, c::Real=0.0)
-    if d != -1
-        Base.depwarn(
-            "keyword argument `d` is deprecated, use `degree` instead",
-            :PiecewisePolynomialKernel,
-        )
-        isinteger(d) || error("polynomial degree has to be an integer")
-        degree::Int = convert(Int, d)
-    end
+function PolynomialKernel(; degree::Int=2, c::Real=0.0)
     return PolynomialKernel{typeof(c)}(degree, [c])
 end
 

src/deprecated.jl

@@ -7,18 +7,10 @@
 
     k = PiecewisePolynomialKernel(; degree=degree, dim=D)
     k2 = PiecewisePolynomialKernel{degree}(D)
-    k3 = @test_deprecated PiecewisePolynomialKernel{degree}(maha)
-    k4 = @test_deprecated PiecewisePolynomialKernel(; degree=degree, maha=maha)
-    k5 = @test_deprecated PiecewisePolynomialKernel(; v=degree, dim=D)
-    k6 = @test_deprecated PiecewisePolynomialKernel(; v=degree, maha=maha)
 
     @test k2(v1, v2) == k(v1, v2)
-    @test k3(v1, v2) ≈ k(v1, v2)
-    @test k4(v1, v2) ≈ k(v1, v2)
-    @test k5(v1, v2) ≈ k(v1, v2)
-    @test k6(v1, v2) ≈ k(v1, v2)
 
-    @test_throws ErrorException PiecewisePolynomialKernel{4}(maha)
+    @test_throws MethodError PiecewisePolynomialKernel{4}(maha)
     @test_throws ErrorException PiecewisePolynomialKernel{4}(D)
     @test_throws ErrorException PiecewisePolynomialKernel{degree}(-1)
     @test_throws ErrorException PiecewisePolynomialKernel()

test/basekernels/maha.jl

@@ -34,15 +34,9 @@
         @test metric(PolynomialKernel(; degree=3)) == KernelFunctions.DotProduct()
         @test metric(PolynomialKernel(; degree=3, c=c)) == KernelFunctions.DotProduct()
 
-        # Deprecations.
-        k = @test_deprecated PolynomialKernel(; d=1)
-        @test k.degree == 1
-
         # Errors.
-        @test_throws ArgumentError PolynomialKernel(; d=0)
         @test_throws ArgumentError PolynomialKernel(; degree=0)
         @test_throws ArgumentError PolynomialKernel(; c=-0.5)
-        @test_throws ErrorException PolynomialKernel(; d=2.5)
 
         # Standardised tests.
         TestUtils.test_interface(k, Float64)

test/basekernels/piecewisepolynomial.jl

@@ -27,12 +27,6 @@
         end
     end
 
-    # Deprecations
-    @test TensorProduct === KernelTensorProduct
-    @test TensorProduct(k1, k2) == k1 ⊗ k2
-    @test TensorProduct((k1, k2)) == k1 ⊗ k2
-    @test TensorProduct([k1, k2]) == k1 ⊗ k2
-
     # Standardised tests.
     TestUtils.test_interface(kernel1, ColVecs{Float64})
     TestUtils.test_interface(kernel1, RowVecs{Float64})