Skip to content

Commit 235cd57

Browse files
committed
Removed obsdim in vec_of_vecs as keyword replaced as a positional
1 parent f88bef6 commit 235cd57

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/utils.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ end
1212

1313
# abstract type VecOfVecs{T, TX <: AbstractMatrix{T}, S} <: AbstractVector{S} end
1414

15-
function vec_of_vecs(X::AbstractMatrix; obsdim = 1)
15+
function vec_of_vecs(X::AbstractMatrix, obsdim)
1616
@assert obsdim (1, 2) "obsdim should be 1 or 2"
1717
if obsdim == 1
1818
RowVecs(X)

test/utils.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
rng, N, D = MersenneTwister(123456), 10, 4
44
x, X = randn(rng, N), randn(rng, D, N)
55
@testset "VecOfVecs" begin
6-
@test vec_of_vecs(X, obsdim = 2) == ColVecs(X)
7-
@test vec_of_vecs(X, obsdim = 1) == RowVecs(X)
6+
@test vec_of_vecs(X, 2) == ColVecs(X)
7+
@test vec_of_vecs(X, 1) == RowVecs(X)
88
end
99
# Test Matrix data sets.
1010
@testset "ColVecs" begin

0 commit comments

Comments
 (0)