Skip to content

Commit 682bae7

Browse files
committed
Corrected inplace operations
1 parent 2b27baa commit 682bae7

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

src/kernelmatrix.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ function kernelmatrix!(
1212
symmetrize::Bool = true
1313
) where {T,T₁<:Real,T₂<:Real}
1414
@assert check_dims(K,X,X,obsdim) "Dimensions of the target array are not consistent with X and Y"
15-
map!(K,x->kappa(κ,x),pairwise(metric(κ),transform(κ,X,obsdim),dims=obsdim))
15+
map!(x->kappa(κ,x),K,pairwise(metric(κ),transform(κ,X,obsdim),dims=obsdim))
1616
end
1717

1818
"""
@@ -29,7 +29,7 @@ function kernelmatrix!(
2929
obsdim::Int = defaultobs
3030
) where {T,T₁,T₂,T₃}
3131
@assert check_dims(K,X,Y,obsdim) "Dimensions of the target array are not consistent with X and Y"
32-
map!(K,x->kappa(κ,x),pairwise(metric(κ),transform(κ,X,obsdim),transform(κ,Y,obsdim),dims=obsdim))
32+
map!(x->kappa(κ,x),K,pairwise(metric(κ),transform(κ,X,obsdim),transform(κ,Y,obsdim),dims=obsdim))
3333
end
3434

3535
"""

src/utils.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ end
2222
function check_dims(K,X,Y,obsdim)
2323
if size(X,obsdim) == size(Y,obsdim)
2424
if obsdim == 1
25-
return size(K) == (size(X,2),size(Y,2))
26-
elseif obsdim == 2
2725
return size(K) == (size(X,1),size(Y,1))
26+
elseif obsdim == 2
27+
return size(K) == (size(X,2),size(Y,2))
2828
end
2929
end
3030
return false

test/runtests.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,7 @@ include("test_util.jl")
1111
@testset "KernelFunctions" begin
1212
include("zygote_rules.jl")
1313
include("kernelmatrix.jl")
14-
include("constructors.jl")
14+
include("constructors.jl")
15+
include("testAD.jl")
16+
#include("types.jl")
1517
end

0 commit comments

Comments
 (0)