Spread tests for all base kernels

theogf · theogf · commit 960bad2df286 · 2020-05-16T19:04:44.000+02:00
diff --git a/test/basekernels/constant.jl b/test/basekernels/constant.jl
@@ -5,7 +5,7 @@
         @test kappa(k,2.0) == 0.0
         @test KernelFunctions.metric(ZeroKernel()) == KernelFunctions.Delta()
         @test repr(k) == "Zero Kernel"
-        test_AD("Zero", ZeroKernel)
+        test_ADs(ZeroKernel)
     end
     @testset "WhiteKernel" begin
         k = WhiteKernel()
@@ -15,7 +15,7 @@
         @test EyeKernel == WhiteKernel
         @test metric(WhiteKernel()) == KernelFunctions.Delta()
         @test repr(k) == "White Kernel"
-        test_AD("WhiteKernel", WhiteKernel)
+        test_ADs(WhiteKernel)
     end
     @testset "ConstantKernel" begin
         c = 2.0
@@ -26,6 +26,6 @@
         @test metric(ConstantKernel()) == KernelFunctions.Delta()
         @test metric(ConstantKernel(c=2.0)) == KernelFunctions.Delta()
         @test repr(k) == "Constant Kernel (c = $(c))"
-        test_AD("ConstantKernel", c->ConstantKernel(c=first(c)), [c])
+        test_ADs(c->ConstantKernel(c=first(c)), [c])
     end
 end
diff --git a/test/basekernels/cosine.jl b/test/basekernels/cosine.jl
@@ -12,4 +12,5 @@
     @test kappa(k,x) ≈ cospi(x) atol=1e-5
     @test k(v1, v2) ≈ cospi(sqrt(sum(abs2.(v1-v2)))) atol=1e-5
     @test repr(k) == "Cosine Kernel"
+    test_ADs(CosineKernel)
 end
diff --git a/test/basekernels/exponential.jl b/test/basekernels/exponential.jl
@@ -14,6 +14,7 @@
         @test SEKernel == SqExponentialKernel
         @test repr(k) == "Squared Exponential Kernel"
         @test KernelFunctions.iskroncompatible(k) == true
+        test_ADs(SEKernel)
     end
     @testset "ExponentialKernel" begin
         k = ExponentialKernel()
@@ -24,6 +25,7 @@
         @test repr(k) == "Exponential Kernel"
         @test LaplacianKernel == ExponentialKernel
         @test KernelFunctions.iskroncompatible(k) == true
+        test_ADs(ExponentialKernel)
     end
     @testset "GammaExponentialKernel" begin
         γ = 2.0
@@ -36,7 +38,8 @@
         @test metric(GammaExponentialKernel(γ=2.0)) == SqEuclidean()
         @test repr(k) == "Gamma Exponential Kernel (γ = $(γ))"
         @test KernelFunctions.iskroncompatible(k) == true
-
+        test_ADs(γ -> GammaExponentialKernel(gamma=first(γ)), [γ], ADs = [:ForwardDiff, :ReverseDiff])
+        @test_broken "Zygote gradient given γ"
         #Coherence :
         @test GammaExponentialKernel(γ=1.0)(v1,v2) ≈ SqExponentialKernel()(v1,v2)
         @test GammaExponentialKernel(γ=0.5)(v1,v2) ≈ ExponentialKernel()(v1,v2)
diff --git a/test/basekernels/exponentiated.jl b/test/basekernels/exponentiated.jl
@@ -10,4 +10,5 @@
     @test k(v1,v2) ≈ exp(dot(v1,v2))
     @test metric(ExponentiatedKernel()) == KernelFunctions.DotProduct()
     @test repr(k) == "Exponentiated Kernel"
+    test_ADs(ExponentiatedKernel)
 end
diff --git a/test/basekernels/fbm.jl b/test/basekernels/fbm.jl
@@ -21,4 +21,6 @@
     @test kernelmatrix(k, x1*ones(1,1), x2*ones(1,1))[1] ≈ k(x1, x2) atol=1e-5
 
     @test repr(k) == "Fractional Brownian Motion Kernel (h = $(h))"
+    test_ADs(FBMKernel, ADs = [:ReverseDiff])
+    @test_broken "Tests failing for kernelmatrix(k, x) for ForwardDiff and Zygote"
 end
diff --git a/test/basekernels/gabor.jl b/test/basekernels/gabor.jl
@@ -17,4 +17,6 @@
     @test k.ell ≈ 1.0 atol=1e-5
     @test k.p ≈ 1.0 atol=1e-5
     @test repr(k) == "Gabor Kernel (ell = 1.0, p = 1.0)"
+    test_ADs(x -> GaborKernel(ell = x[1], p = x[2]), [ell, p], ADs = [:ForwardDiff, :ReverseDiff])
+    @test_broken "Tests failing for Zygote on differentiating through ell and p"
 end
diff --git a/test/basekernels/maha.jl b/test/basekernels/maha.jl
@@ -11,4 +11,6 @@
     @test k(v1, v2) ≈ exp(-sqmahalanobis(v1, v2, P))
     @test kappa(ExponentialKernel(), x) == kappa(k, x)
     @test repr(k) == "Mahalanobis Kernel (size(P) = $(size(P)))"
+    # test_ADs(P -> MahalanobisKernel(P), P)
+    @test_broken "Nothing passes (problem with Mahalanobis distance in Distances)"
 end
diff --git a/test/basekernels/matern.jl b/test/basekernels/matern.jl
@@ -14,6 +14,8 @@
         @test metric(MaternKernel()) == Euclidean()
         @test metric(MaternKernel(ν=2.0)) == Euclidean()
         @test repr(k) == "Matern Kernel (ν = $(ν))"
+        test_ADs(x->MaternKernel(nu=first(x)),[ν])
+        @test_broken "All fails (because of logabsgamma for ForwardDiff and ReverseDiff and because of nu for Zygote)"
     end
     @testset "Matern32Kernel" begin
         k = Matern32Kernel()
@@ -22,6 +24,7 @@
         @test kappa(Matern32Kernel(),x) == kappa(k,x)
         @test metric(Matern32Kernel()) == Euclidean()
         @test repr(k) == "Matern 3/2 Kernel"
+        test_ADs(Matern32Kernel)
     end
     @testset "Matern52Kernel" begin
         k = Matern52Kernel()
@@ -30,6 +33,7 @@
         @test kappa(Matern52Kernel(),x) == kappa(k,x)
         @test metric(Matern52Kernel()) == Euclidean()
         @test repr(k) == "Matern 5/2 Kernel"
+        test_ADs(Matern52Kernel)
     end
     @testset "Coherence Materns" begin
         @test kappa(MaternKernel(ν=0.5),x) ≈ kappa(ExponentialKernel(),x)
diff --git a/test/basekernels/nn.jl b/test/basekernels/nn.jl
@@ -43,5 +43,6 @@
     @test_throws DimensionMismatch kernelmatrix!(A5, k, ones(4,3), ones(3,4))
 
     @test k([x1], [x2]) ≈ k(x1, x2) atol=1e-5
-
+    test_ADs(NeuralNetworkKernel, ADs = [:ForwardDiff, :ReverseDiff])
+    @test_broken "Zygote uncompatible with BaseKernel"
 end
diff --git a/test/basekernels/periodic.jl b/test/basekernels/periodic.jl
@@ -7,4 +7,6 @@
     @test k(v1, v2) == k(v2, v1)
     @test PeriodicKernel(3)(v1, v2) == PeriodicKernel(r = ones(3))(v1, v2)
     @test repr(k) == "Periodic Kernel, length(r) = $(length(r)))"
+    test_ADs(r->PeriodicKernel(r =r), r, ADs = [:ForwardDiff, :ReverseDiff])
+    @test_broken "Undefined adjoint for Sinus metric"
 end
diff --git a/test/basekernels/piecewisepolynomial.jl b/test/basekernels/piecewisepolynomial.jl
@@ -29,7 +29,9 @@
     kerneldiagmatrix!(A3, k, m1)
     @test A3 == kerneldiagmatrix(k, m1)
 
-    @test repr(k) == "Piecewise Polynomial Kernel (v = $(v), size(maha) = $(size(maha)))"
-
     @test_throws ErrorException PiecewisePolynomialKernel{4}(maha)
+
+    @test repr(k) == "Piecewise Polynomial Kernel (v = $(v), size(maha) = $(size(maha)))"
+    # test_ADs(maha-> PiecewisePolynomialKernel(v=2, maha = maha), maha)
+    @test_broken "Nothing passes (problem with Mahalanobis distance in Distances)"
 end
diff --git a/test/basekernels/polynomial.jl b/test/basekernels/polynomial.jl
@@ -12,6 +12,7 @@
         @test metric(LinearKernel()) == KernelFunctions.DotProduct()
         @test metric(LinearKernel(c=2.0)) == KernelFunctions.DotProduct()
         @test repr(k) == "Linear Kernel (c = 0.0)"
+        test_ADs(x->LinearKernel(c=x[1]), [c])
     end
     @testset "PolynomialKernel" begin
         k = PolynomialKernel()
@@ -24,5 +25,7 @@
         @test metric(PolynomialKernel()) == KernelFunctions.DotProduct()
         @test metric(PolynomialKernel(d=3.0)) == KernelFunctions.DotProduct()
         @test metric(PolynomialKernel(d=3.0,c=2.0)) == KernelFunctions.DotProduct()
+        # test_ADs(x->PolynomialKernel(d=x[1], c=x[2]),[2.0,  c])
+        @test_broken "All, because of the power"
     end
 end
diff --git a/test/basekernels/rationalquad.jl b/test/basekernels/rationalquad.jl
@@ -13,6 +13,7 @@
         @test metric(RationalQuadraticKernel()) == SqEuclidean()
         @test metric(RationalQuadraticKernel(α=2.0)) == SqEuclidean()
         @test repr(k) == "Rational Quadratic Kernel (α = $(α))"
+        test_ADs(x->RationalQuadraticKernel(alpha=x[1]),[α])
     end
     @testset "GammaRationalQuadraticKernel" begin
         k = GammaRationalQuadraticKernel()
@@ -23,9 +24,11 @@
         @test GammaRationalQuadraticKernel(alpha=a).α == [a]
         @test repr(k) == "Gamma Rational Quadratic Kernel (α = 2.0, γ = 2.0)"
         #Coherence test
-        @test kappa(GammaRationalQuadraticKernel(α=a,γ=1.0),x) ≈ kappa(RationalQuadraticKernel(α=a),x)
+        @test kappa(GammaRationalQuadraticKernel(α=a, γ=1.0), x) ≈ kappa(RationalQuadraticKernel(α=a), x)
         @test metric(GammaRationalQuadraticKernel()) == SqEuclidean()
         @test metric(GammaRationalQuadraticKernel(γ=2.0)) == SqEuclidean()
-        @test metric(GammaRationalQuadraticKernel(γ=2.0,α=3.0)) == SqEuclidean()
+        @test metric(GammaRationalQuadraticKernel(γ=2.0, α=3.0)) == SqEuclidean()
+        # test_ADs(x->GammaRationalQuadraticKernel(α=x[1], γ=x[2]), [a, 2.0])
+        @test_broken "All (problem with power operation)"
     end
 end
diff --git a/test/basekernels/sm.jl b/test/basekernels/sm.jl
@@ -21,4 +21,6 @@
     @test_throws DimensionMismatch spectral_mixture_kernel(rand(5) ,rand(4,3), rand(4,3))
     @test_throws DimensionMismatch spectral_mixture_kernel(rand(3) ,rand(4,3), rand(5,3))
     @test_throws DimensionMismatch spectral_mixture_product_kernel(rand(5,3) ,rand(4,3), rand(5,3))
+    # test_ADs(x->spectral_mixture_kernel(exp.(x[1:3]), reshape(x[4:18], 5, 3), reshape(x[19:end], 5, 3)), vcat(log.(αs₁), γs[:], ωs[:]), dims = [5,5])
+    @test_broken "No tests passing (BaseKernel)"
 end
diff --git a/test/basekernels/wiener.jl b/test/basekernels/wiener.jl
@@ -50,4 +50,7 @@
     @test kernelmatrix(k1, x1*ones(1,1), x2*ones(1,1))[1] ≈ k1(x1, x2) atol=1e-5
     @test kernelmatrix(k2, x1*ones(1,1), x2*ones(1,1))[1] ≈ k2(x1, x2) atol=1e-5
     @test kernelmatrix(k3, x1*ones(1,1), x2*ones(1,1))[1] ≈ k3(x1, x2) atol=1e-5
+
+    # test_ADs(()->WienerKernel(i=1))
+    @test_broken "No tests passing"
 end
diff --git a/test/kernels/kernelproduct.jl b/test/kernels/kernelproduct.jl
@@ -47,4 +47,6 @@
             @test kerneldiagmatrix!(tmp_diag, k, x) ≈ kerneldiagmatrix(k, x)
         end
     end
+    test_ADs(x->SqExponentialKernel() * LinearKernel(c= x[1]), rand(1), ADs = [:ForwardDiff, :ReverseDiff])
+    @test_broken "Zygote issue"
 end
diff --git a/test/kernels/kernelsum.jl b/test/kernels/kernelsum.jl
@@ -53,4 +53,6 @@
             @test kerneldiagmatrix!(tmp_diag, k, x) ≈ kerneldiagmatrix(k, x)
         end
     end
+    test_ADs(x->KernelSum([SqExponentialKernel(),LinearKernel(c= x[1])], x[2:3]), rand(3))#, ADs = [:ForwardDiff, :ReverseDiff])
+    @test_broken "Zygote failing because of mutating array"
 end
diff --git a/test/kernels/scaledkernel.jl b/test/kernels/scaledkernel.jl
@@ -40,4 +40,5 @@
             @test_broken kerneldiagmatrix!(tmp_diag, ks, x) ≈ kerneldiagmatrix(ks, x)
         end
     end
+    test_ADs(x->x[1] * SqExponentialKernel(), rand(1))
 end
diff --git a/test/kernels/tensorproduct.jl b/test/kernels/tensorproduct.jl
@@ -110,4 +110,5 @@
             end
         end
     end
+    test_ADs(()->TensorProduct(SqExponentialKernel(), LinearKernel()), dims = [2, 2]) # ADs = [:ForwardDiff, :ReverseDiff])
 end
diff --git a/test/kernels/transformedkernel.jl b/test/kernels/transformedkernel.jl
@@ -47,4 +47,5 @@
             @test kerneldiagmatrix!(tmp_diag, kt, x) ≈ kerneldiagmatrix(kt, x)
         end
     end
+    test_ADs(x->transform(SqExponentialKernel(), x[1]), rand(1))# ADs = [:ForwardDiff, :ReverseDiff])
 end
