One more fix and tests on validate_inputs and validate_inplace_dims

Author: theogf

src/utils.jl

@@ -20,7 +20,7 @@ function vec_of_vecs(X::AbstractMatrix; obsdim::Int = 2)
     end
 end
 
-dim(x::AbstractVector{<:Real}) = 1
+dim(x::AbstractVector{<:AbstractVector{<:Real}}) = length(first(x))
 dim(x::AbstractVector{Tuple{Any,Int}}) = 1
 
 """
@@ -96,7 +96,7 @@ For a transform return its parameters, for a `ChainTransform` return a vector of
 
 
 function validate_inplace_dims(K::AbstractMatrix, x::AbstractVector, y::AbstractVector)
-    validate_dims(x, y)
+    validate_inputs(x, y)
     if size(K) != (length(x), length(y))
         throw(DimensionMismatch(
             "Size of the target matrix K ($(size(K))) not consistent with lengths of " *
@@ -120,7 +120,7 @@ end
 
 validate_inputs(x, y) = nothing
 
-function validate_inputs(x::V, y::V) where {V<:Union{RowVecs, ColVecs}}
+function validate_inputs(x::V, y::V) where {V<:Union{RowVecs, ColVecs, AbstractVector{<:AbstractVector{<:Real}}}}
     if dim(x) != dim(y)
         throw(DimensionMismatch(
             "Dimensionality of x ($(dim(x))) not equality to that of y ($(dim(y)))",

test/utils.jl

@@ -75,4 +75,26 @@
             @test back(ones(size(X)))[1].X == ones(size(X))
         end
     end
+    @testset "input checks" begin
+        D = 3; D⁻ = 2
+        N1 = 2; N2 = 3
+        x = [rand(rng, D) for _ in 1:N1]
+        x⁻ = [rand(rng, D⁻) for _ in 1:N1]
+        y = [rand(rng, D) for _ in 1:N2]
+        xx = [rand(rng, D, D) for _ in 1:N1]
+        xx⁻ = [rand(rng, D, D⁻) for _ in 1:N1]
+        yy = [rand(rng, D, D) for _ in 1:N2]
+        @test_nowarn KernelFunctions.validate_inplace_dims(zeros(N1, N2), x, y)
+        @test_throws DimensionMismatch KernelFunctions.validate_inplace_dims(zeros(N1, N1), x, y)
+        @test_throws DimensionMismatch KernelFunctions.validate_inplace_dims(zeros(N1, N2), x⁻, y)
+        @test_nowarn KernelFunctions.validate_inplace_dims(zeros(N1, N1), x)
+        @test_nowarn KernelFunctions.validate_inplace_dims(zeros(N1), x)
+        @test_throws DimensionMismatch KernelFunctions.validate_inplace_dims(zeros(N2), x)
+
+        @test_nowarn KernelFunctions.validate_inputs(x, y)
+        @test_throws DimensionMismatch KernelFunctions.validate_inputs(x⁻, y)
+
+        @test_nowarn KernelFunctions.validate_inputs(xx, yy)
+        @test_nowarn KernelFunctions.validate_inputs(xx⁻, yy)
+    end
 end