Skip to content

Commit 092bf04

Browse files
committed
Add test for == and fix method
1 parent 73ad032 commit 092bf04

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/parameters_matrix.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ struct PositiveDefinite{TL<:AbstractVector{<:Real},Tε<:Real} <: AbstractParamet
9898
ε::Tε
9999
end
100100

101-
Base.:(==)(X::PositiveDefinite, Y::PositiveDefinite) = X.L == Y.L
101+
Base.:(==)(X::PositiveDefinite, Y::PositiveDefinite) = X.L == Y.L && X.ε == Y.ε
102102

103103
value(X::PositiveDefinite) = A_At(vec_to_tril(X.L)) + X.ε * I
104104

test/parameters_matrix.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ using ParameterHandling: vec_to_tril, tril_to_vec
6161
@test isposdef(value(X))
6262
X.L .= 0 # zero the unconstrained value
6363
@test isposdef(value(X))
64+
@test X != positive_definite(X_mat)
65+
@test positive_definite(X_mat, 1e-3) != positive_definite(X_mat, 1e-2)
6466
@test_throws ArgumentError positive_definite(zeros(3, 3))
6567
@test_throws ArgumentError positive_definite(X_mat, 0.0)
6668
test_parameter_interface(X)

0 commit comments

Comments
 (0)