Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: AlexRobson

src/flatten.jl

@@ -79,7 +79,7 @@ function flatten(::Type{T}, x::Tuple) where {T<:Real}
         r = map(x_backs, lengths, sz) do x_back, l, s
             return x_back(v[(s - l + 1):s])
         end
-        _oftype(x, r)
+        return _oftype(x, r)
     end
     return reduce(vcat, x_vecs), unflatten_to_Tuple
 end

src/parameters.jl

@@ -148,7 +148,7 @@ Base.:(==)(a::Deferred, b::Deferred) = (a.f == b.f) && (a.args == b.args)
 
 value(x::Deferred) = x.f(value(x.args)...)
 
-function flatten(::Type{T}, x::D) where {T<:Real, D<:Deferred}
+function flatten(::Type{T}, x::D) where {T<:Real,D<:Deferred}
     v, unflatten = flatten(T, x.args)
     unflatten_Deferred(v_new::Vector{T}) = D(x.f, unflatten(v_new))
     return v, unflatten_Deferred
@@ -217,7 +217,7 @@ A_At(X) = X * X'
 
 value(X::PositiveDefinite) = A_At(vec_to_tril(X.L))
 
-function flatten(::Type{T}, X::P) where {T<:Real, P<:PositiveDefinite}
+function flatten(::Type{T}, X::P) where {T<:Real,P<:PositiveDefinite}
     v, unflatten_v = flatten(T, X.L)
     unflatten_PositiveDefinite(v_new::Vector{T}) = P(unflatten_v(v_new))
     return v, unflatten_PositiveDefinite

test/flatten.jl

@@ -42,7 +42,7 @@
 
     @testset "Parameters" begin
         test_flatten_interface(positive.([1.0, 2.0]))
-        test_flatten_interface(deferred(vec, [1.0, 2.0],))
+        test_flatten_interface(deferred(vec, [1.0, 2.0]))
         test_flatten_interface(fixed([1.0, 2.0]))
     end
 end

test/parameters.jl

@@ -45,7 +45,6 @@ pdiagmat(args...) = PDiagMat(args...)
             );
             check_inferred=tuple_infers,
         )
-
     end
 
     @testset "orthogonal" begin