Remove time_exp rule #134
Merged
Remove time_exp rule #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It appears that #319 has been solved, but (necessary) work on Mooncake over Christmas introduced some performance regressions. They'll need resolving before I merge this. |
Pull Request Test Coverage Report for Build 13347955004Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of Mooncake supports differentiating through the matrix exponential, so the hacky rule in this package is not needed. As such, this PR removes all of this functionality.
Locally I was seeing a known Mooncake-related problem, so it might be that this PR cannot be resolved until chalk-lab/Mooncake.jl#319 is resolved. See upstream Julialang issue for more info: JuliaLang/julia#56193