enable Aqua tests (issue #20)

Author: Alexander-Barth

Project.toml

@@ -17,5 +17,8 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
 [compat]
 CFTime = "0.1.1"
 DataStructures = "0.17, 0.18"
+Dates = "1"
 Preferences = "1.3"
-julia = "1.6"
+Printf = "1"
+Statistics = "1"
+julia = "1.6"

src/cfvariable.jl

@@ -455,7 +455,7 @@ function Base.setindex!(v::CFVariable,data::Missing,indexes::TIndices...)
     v.var[indexes...] = fillvalue(v)
 end
 
-function Base.setindex!(v::CFVariable,data::Union{T,Array{T,N}},indexes::TIndices...) where N where T <: Union{AbstractCFDateTime,DateTime,Union{Missing,DateTime,AbstractCFDateTime}}
+function Base.setindex!(v::CFVariable,data::Union{T,Array{T}},indexes::TIndices...) where T <: Union{AbstractCFDateTime,DateTime,Missing}
 
     if calendar(v) !== nothing
         # can throw an convertion error if calendar attribute already exists and

src/rolling.jl

@@ -11,8 +11,8 @@ end
 
 
 # multiple classes for overlapping groups
-struct MClass{N,TC}
-    class::NTuple{N,TC}
+struct MClass{T <: NTuple}
+    class::T
 end
 
 Base.length(mc::MClass) = 1

test/Project.toml

@@ -1,4 +1,5 @@
 [deps]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 CFTime = "179af706-886a-5703-950a-314cd64e0468"
 DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
@@ -8,3 +9,6 @@ NCDatasets = "85f8d34a-cbdd-5861-8df4-14fed0d494ab"
 Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
 Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
+
+[compat]
+Aqua = "0.8"

test/runtests.jl

@@ -34,3 +34,7 @@ end
     include("test_groupby.jl")
     include("test_rolling.jl")
 end
+
+@testset "aqua checks" begin
+    include("test_aqua.jl")
+end

test/test_aqua.jl

@@ -1,4 +1,4 @@
 using Aqua
 using CommonDataModel
 
-Aqua.test_ambiguities(CommonDataModel)
+Aqua.test_all(CommonDataModel)